Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2341783005: mash: Fix Chrome crash accessing chrome://settings. (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, James Cook, rjkroege, Daniel Erat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix Chrome crash accessing chrome://settings. Avoid Shell and PowerStatus access for display/power options. BUG=646558, 548429, 644348 TEST=No crash accessing chrome://settings in chrome --mash. R=stevenjb@chromium.org Committed: https://crrev.com/bc32dfbb9d481c8d93efe038569f3a6d81267db5 Cr-Commit-Position: refs/heads/master@{#418731}

Patch Set 1 #

Patch Set 2 : Avoid PowerStatus access; not init in Chrome. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/power_handler.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
msw
Hey Steven, please take a look; thanks! +CC James, Robert, Dan: lmk if I should ...
4 years, 3 months ago (2016-09-14 23:54:20 UTC) #3
stevenjb
lgtm
4 years, 3 months ago (2016-09-15 00:15:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341783005/20001
4 years, 3 months ago (2016-09-15 00:46:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 00:52:45 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 00:56:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc32dfbb9d481c8d93efe038569f3a6d81267db5
Cr-Commit-Position: refs/heads/master@{#418731}

Powered by Google App Engine
This is Rietveld 408576698