Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2341773002: Remove test_dll from the list of dependencies of common_lib. (Closed)

Created:
4 years, 3 months ago by Sébastien Marchand
Modified:
4 years, 3 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Remove test_dll from the list of dependencies of common_lib. test_dll is a test artifact but common_lib is used by our binaries, so this dependency introduce a dependency between our tools and some test code. E.g. In order to compile SyzyAsan for x64 you need to also make test_dll.dll x64 friendly, this doesn't make sense. This doesn't seem to affect the build, it looks like this dependency wasn't needed. Committed: https://github.com/google/syzygy/commit/4ce5e9d641bf96e02d71add440063176a39677b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M syzygy/agent/common/common.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Sébastien Marchand
PTAL.
4 years, 3 months ago (2016-09-14 14:49:46 UTC) #2
Sigurður Ásgeirsson
lgtm
4 years, 3 months ago (2016-09-14 15:12:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341773002/1
4 years, 3 months ago (2016-09-14 15:17:05 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:34:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/google/syzygy/commit/4ce5e9d641bf96e02d71add440063176a39677b3

Powered by Google App Engine
This is Rietveld 408576698