fpdfsdk/pdfwindow/PWL_ComboBox.h - Issue 2341693003: Cleanup CFX_SystemHandler. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(67)

My Issues | Starred Open | Closed | All

Unified Diff: fpdfsdk/pdfwindow/PWL_ComboBox.h

Issue 2341693003: Cleanup CFX_SystemHandler. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« fpdfsdk/formfiller/cffl_formfiller.cpp ('K') | « fpdfsdk/fxedit/include/fxet_edit.h ('k') | fpdfsdk/pdfwindow/PWL_Edit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: fpdfsdk/pdfwindow/PWL_ComboBox.h

diff --git a/fpdfsdk/pdfwindow/PWL_ComboBox.h b/fpdfsdk/pdfwindow/PWL_ComboBox.h

index df9eb5546e8523941d64c3cfe118a1354b75a939..25b564f0ce41920e48f94d6e60d5ee67a497ee6d 100644

--- a/fpdfsdk/pdfwindow/PWL_ComboBox.h

+++ b/fpdfsdk/pdfwindow/PWL_ComboBox.h

@@ -82,7 +82,7 @@ class CPWL_ComboBox : public CPWL_Wnd {

void SetSelectText();

- void AttachFFLData(void* pData) { m_pFormFiller = pData; }

+ void AttachFFLData(CFFL_FormFiller* pData) { m_pFormFiller = pData; }

private:

void CreateEdit(const PWL_CREATEPARAM& cp);

@@ -99,7 +99,7 @@ class CPWL_ComboBox : public CPWL_Wnd {

int32_t m_nSelectItem;

IPWL_Filler_Notify* m_pFillerNotify;

Tom Sepez 2016/09/15 17:00:28 nit: no blank line while we're at it.

dsinclair 2016/09/15 17:19:46 Done.

- void* m_pFormFiller;

+ CFFL_FormFiller* m_pFormFiller; // Not owned.

};

#endif // FPDFSDK_PDFWINDOW_PWL_COMBOBOX_H_

« fpdfsdk/formfiller/cffl_formfiller.cpp ('K') | « fpdfsdk/fxedit/include/fxet_edit.h ('k') | fpdfsdk/pdfwindow/PWL_Edit.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698