Cleanup CFX_SystemHandler.

Cleanup CFX_SystemHandler.

This CL cleans up signatures and code in CFX_SystemHandler.

Committed: https://pdfium.googlesource.com/pdfium/+/8faac627c4562098c62f8497e56a44500c3c199b

[dsinclair, 2016-09-14 19:40:35]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-14 19:40:46]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-09-14 19:40:46]

PTAL.

[commit-bot: I haz the power, 2016-09-14 20:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:08:57]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-15 17:00:28]

lgtm

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/formfiller/cffl_for...
File fpdfsdk/formfiller/cffl_formfiller.cpp (right):

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/formfiller/cffl_for...
fpdfsdk/formfiller/cffl_formfiller.cpp:370: cp.hAttachedWnd = m_pWidget;
nit: can this member be called pAttachedWidget or some such?

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/pdfwindow/PWL_Combo...
File fpdfsdk/pdfwindow/PWL_ComboBox.h (right):

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/pdfwindow/PWL_Combo...
fpdfsdk/pdfwindow/PWL_ComboBox.h:101: 
nit: no blank line while we're at it.

[dsinclair, 2016-09-15 17:19:46]

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/formfiller/cffl_for...
File fpdfsdk/formfiller/cffl_formfiller.cpp (right):

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/formfiller/cffl_for...
fpdfsdk/formfiller/cffl_formfiller.cpp:370: cp.hAttachedWnd = m_pWidget;
On 2016/09/15 17:00:28, Tom Sepez wrote:
> nit: can this member be called pAttachedWidget or some such?

Done.

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/pdfwindow/PWL_Combo...
File fpdfsdk/pdfwindow/PWL_ComboBox.h (right):

https://codereview.chromium.org/2341693003/diff/1/fpdfsdk/pdfwindow/PWL_Combo...
fpdfsdk/pdfwindow/PWL_ComboBox.h:101: 
On 2016/09/15 17:00:28, Tom Sepez wrote:
> nit: no blank line while we're at it.

Done.

[dsinclair, 2016-09-15 17:20:10]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-15 17:20:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2341693003/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-09-15 17:20:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 19:41:52]

Description was changed from

==========
Cleanup CFX_SystemHandler.

This CL cleans up signatures and code in CFX_SystemHandler.
==========

to

==========
Cleanup CFX_SystemHandler.

This CL cleans up signatures and code in CFX_SystemHandler.

Committed:
https://pdfium.googlesource.com/pdfium/+/8faac627c4562098c62f8497e56a44500c3c...
==========

[commit-bot: I haz the power, 2016-09-15 19:41:54]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/8faac627c4562098c62f8497e56a44500c3c...