Add string pools to save storage.

Add string pools to save storage.

Adds string hashes so CFX strings will interoperate with
STL unordered containers.

These will be employed per-document in a subsequent cl.

BUG=pdfium:597
Committed: https://pdfium.googlesource.com/pdfium/+/d9871435eb7cea00a173baf780934f9d3525329a

[Tom Sepez, 2016-09-15 18:55:40]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:55:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-15 18:56:03]

Description was changed from

==========
Add string pools to save storage.

BUG=pdfium:597
==========

to

==========
Add string pools to save storage.

BUG=pdfium:597
==========

[Tom Sepez, 2016-09-15 18:56:03]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-15 18:56:16]

Dan, for review.

[Tom Sepez, 2016-09-15 18:56:39]

Description was changed from

==========
Add string pools to save storage.

BUG=pdfium:597
==========

to

==========
Add string pools to save storage.

These will be employed per-document in a subsequent cl.

BUG=pdfium:597
==========

[Tom Sepez, 2016-09-15 18:58:24]

Description was changed from

==========
Add string pools to save storage.

These will be employed per-document in a subsequent cl.

BUG=pdfium:597
==========

to

==========
Add string pools to save storage.

Adds string hashes so CFX strings will interoperate with
STL unordered containers.

These will be employed per-document in a subsequent cl.

BUG=pdfium:597
==========

[commit-bot: I haz the power, 2016-09-15 18:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:59:19]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/769)

[Tom Sepez, 2016-09-15 19:06:41]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 19:06:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:09:17]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-15 20:23:26]

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
File core/fxcrt/cfx_string_pool_template_unittest.cpp (right):

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:18: // Underlying storage, if
non-null, is not shared.
Doesn't this check that the underlying storage is null?

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:33: 
Should EXPECT_EQ(interned_goats1, interned_goats2) be true as well?

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:42: CFX_ByteString
reinterned_null1 = pool.Intern(null2);
Is it intentional that the null1 and goats1 are pointed at the 2 versions? 
(Maybe add a comment to say so)

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/include/fx_s...
File core/fxcrt/include/fx_string.h (right):

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/include/fx_s...
core/fxcrt/include/fx_string.h:452: namespace std {
Are we allowed to put things into namespace std?

[Tom Sepez, 2016-09-15 20:51:24]

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
File core/fxcrt/cfx_string_pool_template_unittest.cpp (right):

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:18: // Underlying storage, if
non-null, is not shared.
On 2016/09/15 20:23:26, dsinclair wrote:
> Doesn't this check that the underlying storage is null?
Yes, I think that's inline with the comment, for all vars, assert either null or
shared.

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:33: 
On 2016/09/15 20:23:26, dsinclair wrote:
> Should EXPECT_EQ(interned_goats1, interned_goats2) be true as well?

Yes, but that should be covered by the basic string tests.  Also transitivity
...

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:42: CFX_ByteString
reinterned_null1 = pool.Intern(null2);
On 2016/09/15 20:23:26, dsinclair wrote:
> Is it intentional that the null1 and goats1 are pointed at the 2 versions? 
> (Maybe add a comment to say so)
Yes, otherwise they're not equal.

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/include/fx_s...
File core/fxcrt/include/fx_string.h (right):

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/include/fx_s...
core/fxcrt/include/fx_string.h:452: namespace std {
On 2016/09/15 20:23:26, dsinclair wrote:
> Are we allowed to put things into namespace std?

See https://cs.chromium.org/chromium/src/base/optional.h?rcl=0&l=463 for
precedent.

[Tom Sepez, 2016-09-15 20:52:38]

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
File core/fxcrt/cfx_string_pool_template_unittest.cpp (right):

https://codereview.chromium.org/2341683005/diff/20001/core/fxcrt/cfx_string_p...
core/fxcrt/cfx_string_pool_template_unittest.cpp:21: EXPECT_NE(goats1.m_pData,
goats2.m_pData);
Note that we don't get here because operator== on shared ptrs.

[dsinclair, 2016-09-15 21:01:07]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-15 21:01:08]

lgtm

[commit-bot: I haz the power, 2016-09-15 21:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:01:33]

Description was changed from

==========
Add string pools to save storage.

Adds string hashes so CFX strings will interoperate with
STL unordered containers.

These will be employed per-document in a subsequent cl.

BUG=pdfium:597
==========

to

==========
Add string pools to save storage.

Adds string hashes so CFX strings will interoperate with
STL unordered containers.

These will be employed per-document in a subsequent cl.

BUG=pdfium:597

Committed:
https://pdfium.googlesource.com/pdfium/+/d9871435eb7cea00a173baf780934f9d3525...
==========

[commit-bot: I haz the power, 2016-09-15 21:01:34]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d9871435eb7cea00a173baf780934f9d3525...