Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/site_per_process_interactive_browsertest.cc

Issue 2341683004: Disable FullscreenElementInSubframe test on Windows due to being flaky. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/site_per_process_interactive_browsertest.cc
diff --git a/chrome/browser/site_per_process_interactive_browsertest.cc b/chrome/browser/site_per_process_interactive_browsertest.cc
index 3cbea83b464c7ce83f7556c0d9c6a1a3e553ca46..da191b4d974b0b5bfc7616e78b4b838003709477 100644
--- a/chrome/browser/site_per_process_interactive_browsertest.cc
+++ b/chrome/browser/site_per_process_interactive_browsertest.cc
@@ -387,8 +387,15 @@ void WaitForMultipleFullscreenEvents(
// - document.webkitFullscreenElement is correctly updated in both frames.
// - fullscreenchange events fire in both frames.
// - fullscreen CSS is applied correctly in both frames.
+//
+// Flaky on Windows: https://crbug.com/647311
+#if defined(OS_WIN)
+#define MAYBE_FullscreenElementInSubframe DISABLED_FullscreenElementInSubframe
+#else
+#define MAYBE_FullscreenElementInSubframe FullscreenElementInSubframe
+#endif
IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
- FullscreenElementInSubframe) {
+ MAYBE_FullscreenElementInSubframe) {
// Start on a page with one subframe (id "child-0") that has
// "allowfullscreen" enabled.
GURL main_url(embedded_test_server()->GetURL(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698