Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2341673004: [Binding] Replace 'Unscopeable' with 'Unscopable' (Closed)

Created:
4 years, 3 months ago by peria
Modified:
4 years, 3 months ago
Reviewers:
haraken, hayato, Yuki
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace 'Unscopeable' with 'Unscopable' This is a mechanical change, using $ sed -i -e ''s/\([Uu]\)nscopeable/\1nscopable/g' * Plus, updates a test file LayoutTests/fast/js/unscop(e)able.html to use testharness.html. It also removes the expected file. BUG=647133 Committed: https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c Cr-Commit-Position: refs/heads/master@{#418875}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -160 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/ChildNode/after.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ChildNode/before.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ChildNode/replace-with.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ParentNode/append.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ParentNode/prepend.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/js/unscopable.html View 1 chunk +34 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/unscopeable.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/unscopeable-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial3.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 8 chunks +54 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildNode.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ParentNode.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
peria
PTL
4 years, 3 months ago (2016-09-15 13:09:55 UTC) #8
Yuki
lgtm
4 years, 3 months ago (2016-09-15 13:11:13 UTC) #9
haraken
LGTM
4 years, 3 months ago (2016-09-15 13:54:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341673004/40001
4 years, 3 months ago (2016-09-15 14:03:27 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-09-15 15:53:46 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 15:55:15 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c
Cr-Commit-Position: refs/heads/master@{#418875}

Powered by Google App Engine
This is Rietveld 408576698