Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: chrome/BUILD.gn

Issue 2341673003: gn: Generalize process_version() and move it to build/util (take #2) (Closed)
Patch Set: Rebase patch Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/util/version.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
11 import("//build/config/ui.gni") 11 import("//build/config/ui.gni")
12 import("//build/config/win/console_app.gni") 12 import("//build/config/win/console_app.gni")
13 import("//build/config/win/manifest.gni") 13 import("//build/config/win/manifest.gni")
14 import("//chrome/chrome_paks.gni") 14 import("//chrome/chrome_paks.gni")
15 import("//chrome/common/features.gni") 15 import("//chrome/common/features.gni")
16 import("//chrome/version.gni") 16 import("//chrome/process_version_rc_template.gni")
17 import("//third_party/widevine/cdm/widevine.gni") 17 import("//third_party/widevine/cdm/widevine.gni")
18 import("//ui/base/ui_features.gni") 18 import("//ui/base/ui_features.gni")
19 import("//v8/gni/v8.gni") 19 import("//v8/gni/v8.gni")
20 20
21 if (is_android) { 21 if (is_android) {
22 import("//build/config/android/rules.gni") 22 import("//build/config/android/rules.gni")
23 } else if (is_mac) { 23 } else if (is_mac) {
24 import("//build/compiled_action.gni") 24 import("//build/compiled_action.gni")
25 import("//build/config/mac/rules.gni") 25 import("//build/config/mac/rules.gni")
26 import("//build/config/mac/symbols.gni") 26 import("//build/config/mac/symbols.gni")
(...skipping 1157 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 "//content/public/child", 1184 "//content/public/child",
1185 "//third_party/WebKit/public:blink_devtools_frontend_resources", 1185 "//third_party/WebKit/public:blink_devtools_frontend_resources",
1186 ] 1186 ]
1187 1187
1188 if (enable_nacl) { 1188 if (enable_nacl) {
1189 public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ] 1189 public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
1190 } 1190 }
1191 } 1191 }
1192 1192
1193 if (is_win) { 1193 if (is_win) {
1194 process_version("chrome_exe_version") { 1194 process_version_rc_template("chrome_exe_version") {
1195 template_file = chrome_version_rc_template
1196 sources = [ 1195 sources = [
1197 "app/chrome_exe.ver", 1196 "app/chrome_exe.ver",
1198 ] 1197 ]
1199 output = "$target_gen_dir/chrome_exe_version.rc" 1198 output = "$target_gen_dir/chrome_exe_version.rc"
1200 } 1199 }
1201 1200
1202 process_version("chrome_dll_version") { 1201 process_version_rc_template("chrome_dll_version") {
1203 template_file = chrome_version_rc_template
1204 sources = [ 1202 sources = [
1205 "app/chrome_dll.ver", 1203 "app/chrome_dll.ver",
1206 ] 1204 ]
1207 output = "$target_gen_dir/chrome_dll_version.rc" 1205 output = "$target_gen_dir/chrome_dll_version.rc"
1208 } 1206 }
1209 1207
1210 # This manifest matches what GYP produces. It may not even be necessary. 1208 # This manifest matches what GYP produces. It may not even be necessary.
1211 windows_manifest("chrome_dll_manifest") { 1209 windows_manifest("chrome_dll_manifest") {
1212 sources = [ 1210 sources = [
1213 as_invoker_manifest, 1211 as_invoker_manifest,
1214 common_controls_manifest, 1212 common_controls_manifest,
1215 ] 1213 ]
1216 type = "dll" 1214 type = "dll"
1217 } 1215 }
1218 1216
1219 process_version("nacl64_exe_version") { 1217 process_version_rc_template("nacl64_exe_version") {
1220 template_file = chrome_version_rc_template
1221 sources = [ 1218 sources = [
1222 "app/nacl64_exe.ver", 1219 "app/nacl64_exe.ver",
1223 ] 1220 ]
1224 output = "$target_gen_dir/nacl64_exe_version.rc" 1221 output = "$target_gen_dir/nacl64_exe_version.rc"
1225 } 1222 }
1226 1223
1227 process_version("other_version") { 1224 process_version_rc_template("other_version") {
1228 template_file = chrome_version_rc_template
1229 sources = [ 1225 sources = [
1230 "app/other.ver", 1226 "app/other.ver",
1231 ] 1227 ]
1232 output = "$target_gen_dir/other_version.rc" 1228 output = "$target_gen_dir/other_version.rc"
1233 } 1229 }
1234 1230
1235 source_set("file_pre_reader") { 1231 source_set("file_pre_reader") {
1236 sources = [ 1232 sources = [
1237 "app/file_pre_reader_win.cc", 1233 "app/file_pre_reader_win.cc",
1238 "app/file_pre_reader_win.h", 1234 "app/file_pre_reader_win.h",
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
1586 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1582 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1587 "//chrome/tools/build/linux/chrome-wrapper", 1583 "//chrome/tools/build/linux/chrome-wrapper",
1588 "//third_party/xdg-utils/scripts/xdg-mime", 1584 "//third_party/xdg-utils/scripts/xdg-mime",
1589 "//third_party/xdg-utils/scripts/xdg-settings", 1585 "//third_party/xdg-utils/scripts/xdg-settings",
1590 ] 1586 ]
1591 outputs = [ 1587 outputs = [
1592 "$root_out_dir/{{source_file_part}}", 1588 "$root_out_dir/{{source_file_part}}",
1593 ] 1589 ]
1594 } 1590 }
1595 } 1591 }
OLDNEW
« no previous file with comments | « build/util/version.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698