Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2341663002: [compiler] Fix confusion about OSR BailoutId semantics. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Fix confusion about OSR BailoutId semantics. The semantics of the {BailoutId} representing an OSR entry point is different between the interpreter and the full code generator. These semantics are hard-coded in various graph builders. We need to ensure that the correct graph builder is chosen for OSR compilations. R=rmcilroy@chromium.org TEST=mjsunit/regress/regress-5380 BUG=v8:5380 Committed: https://crrev.com/b848716c9810b48126f63c370f9b87dabbb469d6 Cr-Commit-Position: refs/heads/master@{#39444}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M src/compiler.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-5380.js View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-14 08:36:42 UTC) #2
rmcilroy
LGTM, thanks.
4 years, 3 months ago (2016-09-15 10:09:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341663002/20001
4 years, 3 months ago (2016-09-15 10:34:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 11:00:29 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 11:00:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b848716c9810b48126f63c370f9b87dabbb469d6
Cr-Commit-Position: refs/heads/master@{#39444}

Powered by Google App Engine
This is Rietveld 408576698