Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2341653004:
Spellcheck cleanup: chrome/common/owners and obsolete java switch (Closed)
|
Created:
4 years, 3 months ago by timvolodine Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpellcheck cleanup: chrome/common/owners and obsolete java switch
Delete obsolete references to spellcheck files and a switch.
The files listed in chrome/common/owners have been moved to
components/spellcheck/common and are covered by an owners
file there.
The spellcheck switch in ChromeSwitches.java is not used
anywhere (in fact the flag has been removed in
crrev.com/2284583002).
BUG=629609
Committed: https://crrev.com/09cb6ca82acfc3044a5a3c03b02d41397a759e73
Cr-Commit-Position: refs/heads/master@{#419464}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
timvolodine@chromium.org changed reviewers: + groby@chromium.org, rouslan@chromium.org
Description was changed from ========== Spellcheck cleanup: chrome/common/owners and obsolete java switch Delete obsolete references to spellcheck files and a switch. The files listed in chrome/common/owners have been moved to components/spellcheck/common and are covered by an owners file there. The spellcheck switch in ChromeSwitches.java is not used anywhere (in fact the flag has been removed in crrev.com/2284583002). BUG= ========== to ========== Spellcheck cleanup: chrome/common/owners and obsolete java switch Delete obsolete references to spellcheck files and a switch. The files listed in chrome/common/owners have been moved to components/spellcheck/common and are covered by an owners file there. The spellcheck switch in ChromeSwitches.java is not used anywhere (in fact the flag has been removed in crrev.com/2284583002). BUG=629609 ==========
lgtm
lgtm++ https://codereview.chromium.org/2341653004/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java (left): https://codereview.chromium.org/2341653004/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java:132: public static final String ENABLE_ANDROID_SPELLCHECKER = "enable-android-spellchecker"; I just opened the review and thought "Huh - they should probably talk to timvolodine@ before doing that". I suppose you did ;)
https://codereview.chromium.org/2341653004/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java (left): https://codereview.chromium.org/2341653004/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java:132: public static final String ENABLE_ANDROID_SPELLCHECKER = "enable-android-spellchecker"; On 2016/09/15 20:19:26, groby wrote: > I just opened the review and thought "Huh - they should probably talk to > timvolodine@ before doing that". I suppose you did ;) haha you mean I talked to myself.. yes there were no objections ;))
timvolodine@chromium.org changed reviewers: + thakis@chromium.org
+thakis@ : for chrome/ owners RS
lgtm
lgtm
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Spellcheck cleanup: chrome/common/owners and obsolete java switch Delete obsolete references to spellcheck files and a switch. The files listed in chrome/common/owners have been moved to components/spellcheck/common and are covered by an owners file there. The spellcheck switch in ChromeSwitches.java is not used anywhere (in fact the flag has been removed in crrev.com/2284583002). BUG=629609 ========== to ========== Spellcheck cleanup: chrome/common/owners and obsolete java switch Delete obsolete references to spellcheck files and a switch. The files listed in chrome/common/owners have been moved to components/spellcheck/common and are covered by an owners file there. The spellcheck switch in ChromeSwitches.java is not used anywhere (in fact the flag has been removed in crrev.com/2284583002). BUG=629609 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Spellcheck cleanup: chrome/common/owners and obsolete java switch Delete obsolete references to spellcheck files and a switch. The files listed in chrome/common/owners have been moved to components/spellcheck/common and are covered by an owners file there. The spellcheck switch in ChromeSwitches.java is not used anywhere (in fact the flag has been removed in crrev.com/2284583002). BUG=629609 ========== to ========== Spellcheck cleanup: chrome/common/owners and obsolete java switch Delete obsolete references to spellcheck files and a switch. The files listed in chrome/common/owners have been moved to components/spellcheck/common and are covered by an owners file there. The spellcheck switch in ChromeSwitches.java is not used anywhere (in fact the flag has been removed in crrev.com/2284583002). BUG=629609 Committed: https://crrev.com/09cb6ca82acfc3044a5a3c03b02d41397a759e73 Cr-Commit-Position: refs/heads/master@{#419464} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/09cb6ca82acfc3044a5a3c03b02d41397a759e73 Cr-Commit-Position: refs/heads/master@{#419464} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
