chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java - Issue 2341643008: Defaulting all downloads to go through Chrome network stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2341643008: Defaulting all downloads to go through Chrome network stack (Closed)

Patch Set: remove extern Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java ('k') | chrome/app/generated_resources.grd » ('j') | chrome/browser/android/intercept_download_resource_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

index b4b153f4f2ee27d13baebec355283de222136ae1..5bd9f692e91cb2f032a0735884fb64bf31e28b65 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

@@ -34,7 +34,6 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

-import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.ChromeTabbedActivity2;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

@@ -523,8 +522,6 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat

@Override

public boolean isPdfDownload(String url) {

- if (ChromeFeatureList.isEnabled(ChromeFeatureList.SYSTEM_DOWNLOAD_MANAGER)) return false;

String fileExtension = MimeTypeMap.getFileExtensionFromUrl(url);

if (TextUtils.isEmpty(fileExtension)) return false;