Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java

Issue 2341643008: Defaulting all downloads to go through Chrome network stack (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
index 1fb1f393ef1a6535d5849ffb0bfb024860c000d9..e35f8b7a89e3bac5647eec78f1117c5e78a4ae2d 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
@@ -9,7 +9,6 @@ import android.content.pm.ActivityInfo;
import android.content.pm.ResolveInfo;
import android.test.suitebuilder.annotation.SmallTest;
-import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.test.ChromeActivityTestCaseBase;
@@ -104,7 +103,6 @@ public class ExternalNavigationDelegateImplTest extends ChromeActivityTestCaseBa
}
@SmallTest
- @CommandLineFlags.Add({"disable-features=SystemDownloadManager"})
@RetryOnFailure
public void testIsDownload_noSystemDownloadManager() throws Exception {
ExternalNavigationDelegateImpl delegate = new ExternalNavigationDelegateImpl(
@@ -121,15 +119,6 @@ public class ExternalNavigationDelegateImplTest extends ChromeActivityTestCaseBa
delegate.isPdfDownload("http://somesampleurldne.com/copy.txt"));
}
- @SmallTest
- @CommandLineFlags.Add({"enable-features=SystemDownloadManager"})
- public void testIsDownload_withSystemDownloadManager() throws Exception {
- ExternalNavigationDelegateImpl delegate = new ExternalNavigationDelegateImpl(
- getActivity().getActivityTab());
- assertFalse("isDownload should return false with SystemDownloadManager enabled",
- delegate.isPdfDownload("http://somesampeleurldne.com/file.pdf"));
- }
-
@Override
public void startMainActivity() throws InterruptedException {
startMainActivityOnBlankPage();

Powered by Google App Engine
This is Rietveld 408576698