Defaulting all downloads to go through Chrome network stack

chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.download;
 
 import android.app.Activity;
 import android.app.DownloadManager;
 import android.content.ActivityNotFoundException;
 import android.content.BroadcastReceiver;
@@ skipping 16 matching lines @@
 import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
 import org.chromium.base.ObserverList;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.SuppressFBWarnings;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.ChromeFeatureList;
 import org.chromium.chrome.browser.download.ui.BackendProvider;
 import org.chromium.chrome.browser.download.ui.DownloadHistoryAdapter;
 import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;
 import org.chromium.net.ConnectionType;
 import org.chromium.net.NetworkChangeNotifierAutoDetect;
 import org.chromium.net.RegistrationPolicyAlwaysRegister;
 import org.chromium.ui.widget.Toast;
 
 import java.io.File;
 import java.util.ArrayList;
@@ skipping 724 matching lines @@
             }
         }
     }
 
     /**
      * Sends the download request to Android download manager. If |notifyCompleted| is true,
      * a notification will be sent to the user once download is complete and the downloaded
      * content will be saved to the public directory on external storage. Otherwise, the
      * download will be saved in the app directory and user will not get any notifications
      * after download completion.
+     * This will be used by OMA downloads as we need Android DownloadManager to encrypt the content.
      * TODO(qinmin): move this to DownloadManagerDelegate.
      *
      * @param info Download information about the download.
      * @param notifyCompleted Whether to notify the user after Downloadmanager completes the
      *                        download.
      */
     public void enqueueDownloadManagerRequest(
             final DownloadItem item, boolean notifyCompleted) {
         EnqueueDownloadRequestTask task = new EnqueueDownloadRequestTask(item);
         task.execute(notifyCompleted);
@@ skipping 264 matching lines @@
     protected void setDownloadSnackbarController(
             DownloadSnackbarController downloadSnackbarController) {
         mDownloadSnackbarController = downloadSnackbarController;
     }
 
     /**
      * Open the Activity which shows a list of all downloads.
      * @param context Application context
      */
     protected static void openDownloadsPage(Context context) {
-        if (!ChromeFeatureList.isEnabled(ChromeFeatureList.SYSTEM_DOWNLOAD_MANAGER)) {
-            // Try to open Download Home.
-            Activity lastActivity = ApplicationStatus.getLastTrackedFocusedActivity();
-            if (lastActivity instanceof ChromeActivity) {
-                int state = ApplicationStatus.getStateForActivity(lastActivity);
-                if (state >= ActivityState.CREATED && state <= ActivityState.RESUMED) {
-                    ChromeActivity chromeActivity = (ChromeActivity) lastActivity;
-                    DownloadUtils.showDownloadManager(
-                            lastActivity, chromeActivity.getActivityTab());
-                    return;
-                }
+        // Try to open Download Home.
+        Activity lastActivity = ApplicationStatus.getLastTrackedFocusedActivity();
+        if (lastActivity instanceof ChromeActivity) {
+            int state = ApplicationStatus.getStateForActivity(lastActivity);
+            if (state >= ActivityState.CREATED && state <= ActivityState.RESUMED) {
+                ChromeActivity chromeActivity = (ChromeActivity) lastActivity;
+                DownloadUtils.showDownloadManager(
+                        lastActivity, chromeActivity.getActivityTab());
+                return;
             }
         }
 
         // Open the Android Download Manager.
         Intent pageView = new Intent(DownloadManager.ACTION_VIEW_DOWNLOADS);
         pageView.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
         try {
             context.startActivity(pageView);
         } catch (ActivityNotFoundException e) {
             Log.e(TAG, "Cannot find Downloads app", e);
@@ skipping 570 matching lines @@
             boolean isNotificationDismissed);
     private native void nativePauseDownload(long nativeDownloadManagerService, String downloadGuid,
             boolean isOffTheRecord);
     private native void nativeRemoveDownload(long nativeDownloadManagerService, String downloadGuid,
             boolean isOffTheRecord);
     private native void nativeGetAllDownloads(
             long nativeDownloadManagerService, boolean isOffTheRecord);
     private native void nativeCheckForExternallyRemovedDownloads(
             long nativeDownloadManagerService, boolean isOffTheRecord);
 }