ImageCapture browser tests: use IsWebcamAvailableOnSystem()

ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.

Committed: https://crrev.com/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a
Cr-Commit-Position: refs/heads/master@{#419675}

[mcasas, 2016-09-16 01:56:31]

Description was changed from

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

to

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

IsWebcamAvailableOnSystem()s Javascript snippet is corrected
to not use WebRtc's specific returnToTest() method, and to 
search for device.kind 'videoinput' instead of 'video', which
didn't work.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

[mcasas, 2016-09-16 01:57:48]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-16 01:58:03]

Description was changed from

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

IsWebcamAvailableOnSystem()s Javascript snippet is corrected
to not use WebRtc's specific returnToTest() method, and to 
search for device.kind 'videoinput' instead of 'video', which
didn't work.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

to

==========
ImageCapture browser tests: use (and correct) IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

IsWebcamAvailableOnSystem()s Javascript snippet is corrected
to not use WebRtc's specific returnToTest() method, and to 
search for device.kind 'videoinput' instead of 'video', which
didn't work.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

[mcasas, 2016-09-16 03:23:06]

mcasas@chromium.org changed reviewers:
+ lunalu@chromium.org, phoglund@chromium.org

[mcasas, 2016-09-16 03:23:06]

lunalu@ PTAL (touches the code you just landed)

phoglund@ RS plz

[phoglund_chromium, 2016-09-16 09:52:03]

rs lgtm

[phoglund_chromium, 2016-09-16 09:52:19]

Note that the patch was reverted though.

[mcasas, 2016-09-16 16:21:48]

On 2016/09/16 09:52:19, phoglund_chrome_000_sep26 wrote:
> Note that the patch was reverted though.

Yeah, I'll wait until https://crrev.com/2334223012 
lands and rebase against it.

[lunalu1, 2016-09-16 16:56:23]

lgtm

https://codereview.chromium.org/2341643006/diff/20001/content/public/test/bro...
File content/public/test/browser_test_utils.cc (right):

https://codereview.chromium.org/2341643006/diff/20001/content/public/test/bro...
content/public/test/browser_test_utils.cc:421: " 
navigator.mediaDevices.enumerateDevices()"
We can revert these changes now since these have been done in another CL
https://codereview.chromium.org/2334223012/

[mcasas, 2016-09-19 22:39:46]

Description was changed from

==========
ImageCapture browser tests: use (and correct) IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

IsWebcamAvailableOnSystem()s Javascript snippet is corrected
to not use WebRtc's specific returnToTest() method, and to 
search for device.kind 'videoinput' instead of 'video', which
didn't work.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

to

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

[mcasas, 2016-09-19 22:42:17]

https://codereview.chromium.org/2341643006/diff/20001/content/public/test/bro...
File content/public/test/browser_test_utils.cc (right):

https://codereview.chromium.org/2341643006/diff/20001/content/public/test/bro...
content/public/test/browser_test_utils.cc:421: " 
navigator.mediaDevices.enumerateDevices()"
On 2016/09/16 16:56:22, loonybear wrote:
> We can revert these changes now since these have been done in another CL
> https://codereview.chromium.org/2334223012/

Done: PS2 doesn't touch this file anymore.

[mcasas, 2016-09-20 02:55:36]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-09-20 02:55:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org, lunalu@chromium.org
Link to the patchset: https://codereview.chromium.org/2341643006/#ps40001
(title: "Rebase to https://crrev.com/2334223012")

[commit-bot: I haz the power, 2016-09-20 02:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 04:07:26]

Description was changed from

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

to

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

[commit-bot: I haz the power, 2016-09-20 04:07:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-20 04:09:36]

Description was changed from

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.


BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.
==========

to

==========
ImageCapture browser tests: use IsWebcamAvailableOnSystem()

This CL nukes the image_capture_test.html's checkForVideoDevices()
and instead uses the newly introduced IsWebcamAvailableOnSystem()
from browser_test_utils.

BUG=647531
TEST=content_browsertests WebRtcImageCaptureBrowserTest working as before.

Committed: https://crrev.com/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a
Cr-Commit-Position: refs/heads/master@{#419675}
==========

[commit-bot: I haz the power, 2016-09-20 04:09:37]

Patchset 2 (id:??) landed as
https://crrev.com/2be0f67dbdb1f6da85fa5d4ca116daffe7da662a
Cr-Commit-Position: refs/heads/master@{#419675}