Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py

Issue 2341643005: In rebaseline.py, update SCM and expectations all at once after all commands. (Closed)
Patch Set: Add unit test for ChangeSet Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import optparse 5 import optparse
6 6
7 from webkitpy.common.system.outputcapture import OutputCapture 7 from webkitpy.common.system.outputcapture import OutputCapture
8 from webkitpy.tool.commands.optimize_baselines import OptimizeBaselines 8 from webkitpy.tool.commands.optimize_baselines import OptimizeBaselines
9 from webkitpy.tool.commands.rebaseline_unittest import BaseTestCase 9 from webkitpy.tool.commands.rebaseline_unittest import BaseTestCase
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 self.command.execute( 68 self.command.execute(
69 optparse.Values({'suffixes': 'txt,wav,png', 'no_modify_scm': Tru e, 'platform': 'test-mac-mac10.10'}), 69 optparse.Values({'suffixes': 'txt,wav,png', 'no_modify_scm': Tru e, 'platform': 'test-mac-mac10.10'}),
70 ['another/test.html'], 70 ['another/test.html'],
71 self.tool) 71 self.tool)
72 finally: 72 finally:
73 out, _, _ = oc.restore_output() 73 out, _, _ = oc.restore_output()
74 74
75 self.assertEquals( 75 self.assertEquals(
76 out, 76 out,
77 '{"add": [], "remove-lines": [], ' 77 '{"add": [], "remove-lines": [], '
78 '"delete": ["/test.checkout/LayoutTests/platform/test-mac-mac10.10/a nother/test-expected.txt", ' 78 '"delete": ["/test.checkout/LayoutTests/platform/test-mac-mac10.10/a nother/test-expected.png", '
79 '"/test.checkout/LayoutTests/platform/test-mac-mac10.10/another/test -expected.png"]}\n') 79 '"/test.checkout/LayoutTests/platform/test-mac-mac10.10/another/test -expected.txt"]}\n')
80 self.assertFalse( 80 self.assertFalse(
81 self.tool.filesystem.exists(self.tool.filesystem.join( 81 self.tool.filesystem.exists(self.tool.filesystem.join(
82 test_port.layout_tests_dir(), 'platform/mac/another/test-expecte d.txt'))) 82 test_port.layout_tests_dir(), 'platform/mac/another/test-expecte d.txt')))
83 self.assertFalse( 83 self.assertFalse(
84 self.tool.filesystem.exists(self.tool.filesystem.join( 84 self.tool.filesystem.exists(self.tool.filesystem.join(
85 test_port.layout_tests_dir(), 'platform/mac/another/test-expecte d.png'))) 85 test_port.layout_tests_dir(), 'platform/mac/another/test-expecte d.png')))
86 self.assertTrue( 86 self.assertTrue(
87 self.tool.filesystem.exists(self.tool.filesystem.join( 87 self.tool.filesystem.exists(self.tool.filesystem.join(
88 test_port.layout_tests_dir(), 'another/test-expected.txt'))) 88 test_port.layout_tests_dir(), 'another/test-expected.txt')))
89 self.assertTrue( 89 self.assertTrue(
90 self.tool.filesystem.exists(self.tool.filesystem.join( 90 self.tool.filesystem.exists(self.tool.filesystem.join(
91 test_port.layout_tests_dir(), 'another/test-expected.png'))) 91 test_port.layout_tests_dir(), 'another/test-expected.png')))
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698