binding: Indexed properties should accompany with %ArrayProto_values%.

binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935
Committed: https://crrev.com/3d6d14555abd484cf8be6f15e02d8ba5b239cf33
Cr-Commit-Position: refs/heads/master@{#418858}

[Yuki, 2016-09-14 14:49:12]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:49:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-14 14:58:02]

Description was changed from

==========
binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterators

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935
==========

to

==========
binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935
==========

[Yuki, 2016-09-14 15:06:17]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 15:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 16:27:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuki, 2016-09-15 10:43:00]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-15 10:43:29]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org, peria@chromium.org

[Yuki, 2016-09-15 10:43:30]

Could you guys review this CL?

[haraken, 2016-09-15 12:03:42]

LGTM

[peria, 2016-09-15 12:06:44]

lgtm

https://codereview.chromium.org/2341643003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/2341643003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_interface.py:435:
has_array_iterator = True
nit: has_array_iterator = (interface.name != 'Window')  ?

[Yuki, 2016-09-15 12:35:47]

https://codereview.chromium.org/2341643003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/2341643003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_interface.py:435:
has_array_iterator = True
On 2016/09/15 12:06:43, peria wrote:
> nit: has_array_iterator = (interface.name != 'Window')  ?

Done.

[Yuki, 2016-09-15 12:35:52]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-09-15 12:35:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, peria@chromium.org
Link to the patchset: https://codereview.chromium.org/2341643003/#ps80001
(title: "Addressed a review comment.")

[commit-bot: I haz the power, 2016-09-15 12:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 13:48:32]

Description was changed from

==========
binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935
==========

to

==========
binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935
==========

[commit-bot: I haz the power, 2016-09-15 13:48:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-15 13:51:19]

Description was changed from

==========
binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935
==========

to

==========
binding: Indexed properties should accompany with %ArrayProto_values%.

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935

Committed: https://crrev.com/3d6d14555abd484cf8be6f15e02d8ba5b239cf33
Cr-Commit-Position: refs/heads/master@{#418858}
==========

[commit-bot: I haz the power, 2016-09-15 13:51:20]

Patchset 5 (id:??) landed as
https://crrev.com/3d6d14555abd484cf8be6f15e02d8ba5b239cf33
Cr-Commit-Position: refs/heads/master@{#418858}