Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: ui/accessibility/ax_view_state.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Move accessibility notification for text selection being changed to SelectRange() instead. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/ax_view_state.h
diff --git a/ui/accessibility/ax_view_state.h b/ui/accessibility/ax_view_state.h
index a20a65d6e7d41190cf9562522913e6b535b8c0e7..b55f869e8211cabf8b37b1e3e99acaaeb2effd43 100644
--- a/ui/accessibility/ax_view_state.h
+++ b/ui/accessibility/ax_view_state.h
@@ -77,10 +77,11 @@ struct AX_EXPORT AXViewState {
// screen readers, but often used by automation software to script
// things like logging into portals or filling forms.
//
- // This callback is only valid for the lifetime of the view, and should
+ // These callbacks are only valid for the lifetime of the view, and should
// be a safe no-op if the view is deleted. Typically, accessible views
// should use a WeakPtr when binding the callback.
base::Callback<void(const base::string16&)> set_value_callback;
tapted 2016/09/27 07:16:30 Does much change if we require the Callback to hav
Patti Lor 2016/10/20 04:19:34 Done.
+ base::Callback<void(const base::string16&)> replace_selection_callback;
private:
uint32_t state_;

Powered by Google App Engine
This is Rietveld 408576698