ui/accessibility/platform/ax_platform_node_win.cc - Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accessibility/platform/ax_platform_node_win.cc

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)

Patch Set: Review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/accessibility/platform/ax_platform_node_win.cc

diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc

index e73d9a497c3025a810c62a234057a776df8cd5dc..da6501c40c18216ab89742728ac4aabd3839c819 100644

--- a/ui/accessibility/platform/ax_platform_node_win.cc

+++ b/ui/accessibility/platform/ax_platform_node_win.cc

@@ -454,7 +454,7 @@ STDMETHODIMP AXPlatformNodeWin::get_accValue(VARIANT var_id, BSTR* value) {

STDMETHODIMP AXPlatformNodeWin::put_accValue(VARIANT var_id,

BSTR new_value) {

COM_OBJECT_VALIDATE_VAR_ID(var_id);

- if (delegate_->SetStringValue(new_value))

+ if (delegate_->SetStringValue(new_value, true))

return S_OK;

return E_FAIL;

}