Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: ui/accessibility/ax_view_state.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/ax_view_state.h
diff --git a/ui/accessibility/ax_view_state.h b/ui/accessibility/ax_view_state.h
index a20a65d6e7d41190cf9562522913e6b535b8c0e7..aed2727cfeb2483c9fb21c2ec1da1f8012991af5 100644
--- a/ui/accessibility/ax_view_state.h
+++ b/ui/accessibility/ax_view_state.h
@@ -75,12 +75,15 @@ struct AX_EXPORT AXViewState {
// set the string value of this view. This only applies to roles where
// setting the value makes sense, like a text box. Not often used by
// screen readers, but often used by automation software to script
- // things like logging into portals or filling forms.
+ // things like logging into portals or filling forms. If the second argument
+ // is true, this replaces all text with the string given. Otherwise this
+ // inserts at the cursor position, replacing any selected text. The cursor is
+ // placed at the end of the string given.
//
// This callback is only valid for the lifetime of the view, and should
// be a safe no-op if the view is deleted. Typically, accessible views
// should use a WeakPtr when binding the callback.
- base::Callback<void(const base::string16&)> set_value_callback;
+ base::Callback<void(const base::string16&, bool)> set_value_callback;
private:
uint32_t state_;
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | ui/accessibility/platform/ax_platform_node_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698