Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: ui/views/controls/textfield/textfield.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Fix Windows. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index 5eb167deedcdbd5ddb0bbcf9fbbe939a8f3d65cb..72fcab4b933a7752a3a45f881fbf8e242abf53b3 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -365,8 +365,11 @@ class VIEWS_EXPORT Textfield : public View,
// Handles a request to change the value of this text field from software
// using an accessibility API (typically automation software, screen readers
- // don't normally use this). Sets the value and clears the selection.
- void AccessibilitySetValue(const base::string16& new_value);
+ // don't normally use this). If |clear_first| is true, clears the existing
msw 2016/10/27 17:55:09 nit: keep this consistent with any changes to the
Patti Lor 2016/10/31 00:35:05 Done.
+ // value first and sets it to |new_value|. If false, deletes whatever's
+ // selected and replaces it with |new_value|. The cursor is then placed at the
+ // end of |new_value|.
+ void AccessibilitySetValue(const base::string16& new_value, bool clear_first);
// Updates the painted background color.
void UpdateBackgroundColor();

Powered by Google App Engine
This is Rietveld 408576698