Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Fix Windows. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index 2f45573895bc57c1b8bd62c20f7a5c57fcd8ad73..a004c90d3e87a55f6ed160871db92151026eeef4 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -127,8 +127,11 @@ class OmniboxViewViews
// Handles a request to change the value of this text field from software
// using an accessibility API (typically automation software, screen readers
- // don't normally use this). Sets the value and clears the selection.
- void AccessibilitySetValue(const base::string16& new_value);
+ // don't normally use this). If |clear_first| is true, clears the existing
msw 2016/10/27 17:55:09 optional nit: "If |clear_first| is true, this repl
Patti Lor 2016/10/31 00:35:05 Done, thank you!
+ // value first and sets it to |new_value|. If false, deletes whatever's
+ // selected and replaces it with |new_value|. The cursor is then placed at the
+ // end of |new_value|.
+ void AccessibilitySetValue(const base::string16& new_value, bool clear_first);
// Updates |security_level_| based on the toolbar model's current value.
void UpdateSecurityLevel();

Powered by Google App Engine
This is Rietveld 408576698