Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ui/accessibility/platform/ax_platform_node_delegate.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/platform/ax_platform_node_delegate.h
diff --git a/ui/accessibility/platform/ax_platform_node_delegate.h b/ui/accessibility/platform/ax_platform_node_delegate.h
index 1e27f3f00a09f5d3754b07db46ada6405b934882..49dcb7b4f2a1749690bfe799479a3627440b4454 100644
--- a/ui/accessibility/platform/ax_platform_node_delegate.h
+++ b/ui/accessibility/platform/ax_platform_node_delegate.h
@@ -85,9 +85,13 @@ class AX_EXPORT AXPlatformNodeDelegate {
virtual void DoDefaultAction() = 0;
// Change the value of a control, such as the text content of a text field.
- virtual bool SetStringValue(const base::string16& new_value) = 0;
+ // Set |clear_first| to true to clear the existing value first, false to
+ // replace the currently selected text.
+ virtual bool SetStringValue(const base::string16& new_value,
+ bool clear_first) = 0;
- // Whether the string value is settable.
+ // Whether SetStringValue() and ReplaceSelectedText() are callable, i.e. if
dmazzoni 2016/10/26 04:26:02 Update this comment, you don't have a separate Rep
Patti Lor 2016/10/27 00:38:48 Done, thanks.
+ // the string value is read only and if the callback exists.
virtual bool CanSetStringValue() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698