MacViews/a11y: Allow accessibility clients to update the selected text.

chrome/browser/ui/views/omnibox/omnibox_view_views.h

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index 2f45573895bc57c1b8bd62c20f7a5c57fcd8ad73..9f1185f04bf3143540a8c8ef009ff1a36cfd7ff6 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -127,8 +127,9 @@ class OmniboxViewViews
 
   // Handles a request to change the value of this text field from software
   // using an accessibility API (typically automation software, screen readers
-  // don't normally use this). Sets the value and clears the selection.
-  void AccessibilitySetValue(const base::string16& new_value);
+  // don't normally use this). Sets the value and clears the selection. If

[dmazzoni, 2016/10/25 17:21:49]

I'd reword. If |replace| is false, sets the value and clears the selection. If
|replace| is true, deletes whatever's selected and inserts the value.

Hmmm, that seems unclear, |replace| doesn't really do what I'd expect
it to do. Let's rename it so that it's more clear. How about flipping the
boolean like this:

// Replaces the current selection with the text to insert.
// If |clear_first| is true, clears the text field first so
// that it's completely replaced with |text_to_insert|.
AccessibilityInsertText(const base::string16& text_to_insert, bool clear_first);

[Patti Lor, 2016/10/26 00:57:15]

I've changed it to |clear_first|, with the following comment - let me know if
that's clearer:
  // If |clear_first| is true, clears the existing
  // value first and sets it to |new_value|. If false, deletes whatever's
  // selected and replaces it with |new_value|. Then clears the text selection.

+  // |replace| is true, insert at cursor or replace the selection.
+  void AccessibilitySetValue(const base::string16& new_value, bool replace);
 
   // Updates |security_level_| based on the toolbar model's current value.
   void UpdateSecurityLevel();