MacViews/a11y: Allow accessibility clients to update the selected text.

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 #include <utility>
 
 #include "base/trace_event/trace_event.h"
@@ skipping 468 matching lines @@
   return model_->HasCompositionText();
 }
 
 const gfx::Range& Textfield::GetSelectedRange() const {
   return GetRenderText()->selection();
 }
 
 void Textfield::SelectRange(const gfx::Range& range) {
   model_->SelectRange(range);
   UpdateAfterChange(false, true);
+  NotifyAccessibilityEvent(ui::AX_EVENT_TEXT_SELECTION_CHANGED, true);
 }
 
 const gfx::SelectionModel& Textfield::GetSelectionModel() const {
   return GetRenderText()->selection_model();
 }
 
 void Textfield::SelectSelectionModel(const gfx::SelectionModel& sel) {
   model_->SelectSelectionModel(sel);
   UpdateAfterChange(false, true);
 }
@@ skipping 431 matching lines @@
   state->placeholder = GetPlaceholderText();
 
   const gfx::Range range = GetSelectedRange();
   state->selection_start = range.start();
   state->selection_end = range.end();
 
   if (!read_only()) {
     state->set_value_callback =
         base::Bind(&Textfield::AccessibilitySetValue,
                    weak_ptr_factory_.GetWeakPtr());
+    state->replace_selection_callback =
+        base::Bind(&Textfield::AccessibilityReplaceSelection,
+                   weak_ptr_factory_.GetWeakPtr());
   }
 }
 
 void Textfield::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   // Textfield insets include a reasonable amount of whitespace on all sides of
   // the default font list. Fallback fonts with larger heights may paint over
   // the vertical whitespace as needed. Alternate solutions involve undesirable
   // behavior like changing the default font size, shrinking some fallback fonts
   // beyond their legibility, or enlarging controls dynamically with content.
   gfx::Rect bounds = GetContentsBounds();
@@ skipping 820 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // Textfield, private:
 
 void Textfield::AccessibilitySetValue(const base::string16& new_value) {
   if (!read_only()) {
     SetText(new_value);
     ClearSelection();
   }
 }
 
+void Textfield::AccessibilityReplaceSelection(const base::string16& new_value) {
+  if (!read_only()) {
+    InsertOrReplaceText(new_value);
+    ClearSelection();

[tapted, 2016/09/27 07:16:30]

do we want to extend the selection here too?

[Patti Lor, 2016/10/20 04:19:34]

No - Cocoa doesn't, so I was following that behaviour.

+  }
+}
+
 void Textfield::UpdateBackgroundColor() {
   const SkColor color = GetBackgroundColor();
   if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
     set_background(Background::CreateBackgroundPainter(
         true, Painter::CreateSolidRoundRectPainter(
                   color, FocusableBorder::kCornerRadiusDp)));
   } else {
     set_background(Background::CreateSolidBackground(color));
   }
   // Disable subpixel rendering when the background color is transparent
@@ skipping 249 matching lines @@
     UpdateAfterChange(true, true);
   }
   OnAfterUserAction();
 }
 
 void Textfield::OnKeypressUnhandled() {
   PlatformStyle::OnTextfieldKeypressUnhandled();
 }
 
 }  // namespace views