Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2341613006: cros: Fix MD OOBE crash (Closed)

Created:
4 years, 3 months ago by xiyuan
Modified:
4 years, 3 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix MD OOBE crash Reset |oobe_ui_| in ShowLoginScreen is legacy code back when there are separate OobeDisplay and LoginDisplay. OobeDisplay is no longer needed when login screen is shown. This has changed as there is only one LoginDisplay and |oobe_ui_| is used for both OOBE and login. And it should not change during the lifetime of WizardController. BUG=647742 Committed: https://crrev.com/14947f5240be7a4263819e4d80cf3bef350f51d0 Cr-Commit-Position: refs/heads/master@{#419308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
xiyuan
4 years, 3 months ago (2016-09-16 21:42:45 UTC) #2
jdufault
lgtm
4 years, 3 months ago (2016-09-16 21:46:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341613006/1
4 years, 3 months ago (2016-09-16 22:28:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 22:36:37 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 22:39:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14947f5240be7a4263819e4d80cf3bef350f51d0
Cr-Commit-Position: refs/heads/master@{#419308}

Powered by Google App Engine
This is Rietveld 408576698