Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2341613002:
Add descriptions of MemoryState (Closed)
|
Created:
4 years, 3 months ago by bashi Modified:
4 years, 3 months ago Reviewers:
dcheng CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), michaeln Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd descriptions of MemoryState
BUG=617492
Committed: https://crrev.com/c7d2a617004376fad09c83e4845f59636ad0c185
Cr-Commit-Position: refs/heads/master@{#418515}
Patch Set 1 #
Total comments: 6
Patch Set 2 : comments #Messages
Total messages: 15 (8 generated)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bashi@chromium.org changed reviewers: + dcheng@chromium.org
PTAL Excerpt from https://codereview.chromium.org/2311723002/
+michaeln@ FYI
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with nits (since this is a comment-only change, there's no need to wait for another reply from me) https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... File components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom (right): https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom:7: // MemoryState represents status of processes (browser and renderers). Nit: let's comment more about how this enum can be used. So maybe something like: "MemoryState is an indicator that processes can use to guide their memory allocation policies. For example, a process that receives the suspended state can use that as a signal to drop memory caches." https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom:11: // Not encountering memory constrains. Nit: "No memory constraints." https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom:15: // Still in resident memory but its core processing logic has been suspended. Nit: "Still resident in memory but core processing logic has been suspended."
Thank you for the review and the suggestions :) https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... File components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom (right): https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom:7: // MemoryState represents status of processes (browser and renderers). On 2016/09/14 04:46:51, dcheng wrote: > Nit: let's comment more about how this enum can be used. So maybe something > like: > > "MemoryState is an indicator that processes can use to guide their memory > allocation policies. For example, a process that receives the suspended state > can use that as a signal to drop memory caches." Done. https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom:11: // Not encountering memory constrains. On 2016/09/14 04:46:51, dcheng wrote: > Nit: "No memory constraints." Done. https://codereview.chromium.org/2341613002/diff/1/components/memory_coordinat... components/memory_coordinator/public/interfaces/child_memory_coordinator.mojom:15: // Still in resident memory but its core processing logic has been suspended. On 2016/09/14 04:46:51, dcheng wrote: > Nit: "Still resident in memory but core processing logic has been suspended." Done.
The CQ bit was checked by bashi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2341613002/#ps20001 (title: "comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add descriptions of MemoryState BUG=617492 ========== to ========== Add descriptions of MemoryState BUG=617492 Committed: https://crrev.com/c7d2a617004376fad09c83e4845f59636ad0c185 Cr-Commit-Position: refs/heads/master@{#418515} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c7d2a617004376fad09c83e4845f59636ad0c185 Cr-Commit-Position: refs/heads/master@{#418515} |
