Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2341593003: Add a user action for stop in Android. (Closed)
Patch Set: update actions.xml forrealz Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index aee7fbc4374894ab32c1990d6a371fff706ce482..d438af491ab05bb5e3426094f11289e4d38e8d57 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -9369,9 +9369,12 @@ should be able to be added at any place in this file.
</action>
<action name="MobileMenuReload">
- <owner>aurimas@chromium.org</owner>
- <description>User pressed 'Reload' in the app menu.</description>
- <obsolete>This menu item was never added to the app menu.</obsolete>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ User pressed the reload option in the app menu. This was added in M55.
+ Prior to M55, the menu reload counts were combined with the toolbar counts,
+ which were all reported as MobileToolbarReload.
+ </description>
</action>
<action name="MobileMenuRequestDesktopSite">
@@ -9396,6 +9399,11 @@ should be able to be added at any place in this file.
<description>User opened the app menu.</description>
</action>
+<action name="MobileMenuStop">
+ <owner>tedchoc@chromium.org</owner>
+ <description>User pressed the stop option in the app menu.</description>
+</action>
+
<action name="MobileNTP.Interests.Click">
<owner>knn@chromium.org</owner>
<description>
@@ -9771,8 +9779,14 @@ should be able to be added at any place in this file.
</action>
<action name="MobileToolbarReload">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>tedchoc@chromium.org</owner>
+ <description>
+ User pressed the reload icon in the toolbar. Prior to M55, this metric
+ included all reload actions that happened either from the toolbar (tablets)
+ or from the menu (phones). From M55 going forward, this only includes
+ reload actions from the toolbar. Pre-M55, this was the same as
+ MobileToolbarReload summed with MobileMenuReload.
Mark P 2016/09/16 22:00:21 the same as MobileToolbarReload -> the same as wha
Ted C 2016/09/16 23:40:37 Color me quite confused. Is this what you are ask
Mark P 2016/09/19 18:07:35 Yes, indeed. I thought the last sentence was conf
+ </description>
</action>
<action name="MobileToolbarShowMenu">
@@ -9790,6 +9804,11 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="MobileToolbarStop">
+ <owner>tedchoc@chromium.org</owner>
+ <description>User pressed the stop icon in the toolbar.</description>
+</action>
+
<action name="MobileToolbarToggleBookmark">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698