chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 2341593002: [MD settings] ripple on mouse down in side nav

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 2341593002: [MD settings] ripple on mouse down in side nav (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index 429bbb2b23206eaf2b4ececaf3ffc9f18fd56a49..23e548178e390ea962a9739dd7df3360991d94db 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -138,7 +138,7 @@

<paper-submenu class="page-menu" id="advancedPage" actionable

opened="{{advancedOpened_}}"

hidden="[[!pageVisibility.advancedSettings]]">

- <div class="menu-trigger" on-tap="ripple_">

+ <div class="menu-trigger" on-mousedown="ripple_">

Dan Beam 2016/09/15 01:11:09 does this work with touchstart or keydown?

dschuyler 2016/09/16 21:15:18 How about I just use a paper-ripple :)

<span>$i18n{advancedPageTitle}</span>

<iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon>

</div>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | no next file with comments »