Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2341563003: Makes assert_selection() to set focus to sample IFRAME (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes assert_selection() to set focus to sample IFRAME This patch makes |assert_selection()| to set focus to sample IFRAME to ensure |eventSender| and |testRunner.execCommand()| to work on sample IFRAME rather than main frame. The expectation sample of "editing/deleting/delete_by_word.html" is changed to "Ctrl+Backspace", delete by word, deletes word before caret. Before this patch, "Ctrl+Backspace" was sent to main frame and sample IFRAME didn't handle it and did nothing. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/8521c4eb8ba14ca34af6826456e7981a3ed0562b Cr-Commit-Position: refs/heads/master@{#418524}

Patch Set 1 : 2016-09-14T12:42:22 #

Patch Set 2 : 2016-09-14T13:45:43 #

Patch Set 3 : 2016-09-14T14:56:27 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/editing/assert_selection.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/delete_by_word.html View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-14 07:11:34 UTC) #11
Xiaocheng
lgtm
4 years, 3 months ago (2016-09-14 10:20:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341563003/40001
4 years, 3 months ago (2016-09-14 10:21:08 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-14 10:26:04 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 10:29:19 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8521c4eb8ba14ca34af6826456e7981a3ed0562b
Cr-Commit-Position: refs/heads/master@{#418524}

Powered by Google App Engine
This is Rietveld 408576698