[MD Extensions] Add some performance metrics

chrome/browser/ui/webui/extensions/extensions_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extensions_ui.h"
 
+#include <memory>
+
+#include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/timer/elapsed_timer.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/extensions/extension_loader_handler.h"
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 #include "chrome/browser/ui/webui/extensions/install_extension_handler.h"
 #include "chrome/browser/ui/webui/metrics_handler.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/browser_resources.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/google/core/browser/google_util.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "extensions/common/extension_urls.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h"
 #include "chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h"
 #endif
 
 namespace extensions {
 
 namespace {
 
+class ExtensionWebUiTimer : public content::WebContentsObserver {
+ public:
+  explicit ExtensionWebUiTimer(content::WebContents* web_contents, bool is_md)
+      : content::WebContentsObserver(web_contents), is_md_(is_md) {}
+  ~ExtensionWebUiTimer() override {}
+
+  void DidStartProvisionalLoadForFrame(
+      content::RenderFrameHost* render_frame_host,
+      const GURL& validated_url,
+      bool is_error_page,
+      bool is_iframe_srcdoc) override {
+    timer_.reset(new base::ElapsedTimer());
+  }
+
+  void DocumentLoadedInFrame(

[Mark P, 2016/09/14 19:47:31]

side nit: shouldn't you have Main in the function name?

[Devlin, 2016/09/14 19:50:09]

Nope, this overrides a WebContentsObserver method.  We determine it's the main
frame by comparing the render_frame_host with web_contents()->GetMainFrame()
(line 59 of this patch set).

[Mark P, 2016/09/14 20:02:50]

Acknowledged.

+      content::RenderFrameHost* render_frame_host) override {
+    if (render_frame_host != web_contents()->GetMainFrame())
+      return;
+    if (is_md_) {
+      UMA_HISTOGRAM_TIMES("Extensions.WebUi.DocumentLoadedInMainFrameTime.MD",
+                          timer_->Elapsed());
+    } else {
+      UMA_HISTOGRAM_TIMES("Extensions.WebUi.DocumentLoadedInMainFrameTime.Uber",
+                          timer_->Elapsed());
+    }
+  }
+
+  void DocumentOnLoadCompletedInMainFrame() override {
+    if (is_md_) {
+      UMA_HISTOGRAM_TIMES("Extensions.WebUi.LoadCompletedInMainFrame.MD",
+                          timer_->Elapsed());
+    } else {
+      UMA_HISTOGRAM_TIMES("Extensions.WebUi.LoadCompletedInMainFrame.Uber",
+                          timer_->Elapsed());
+    }
+  }
+
+  void WebContentsDestroyed() override { delete this; }
+
+ private:
+  // Whether this is the MD version of the chrome://extensions page.
+  bool is_md_;
+
+  std::unique_ptr<base::ElapsedTimer> timer_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionWebUiTimer);
+};
+
 content::WebUIDataSource* CreateMdExtensionsSource() {
   content::WebUIDataSource* source =
       content::WebUIDataSource::Create(chrome::kChromeUIExtensionsHost);
 
   source->SetJsonPath("strings.js");
 
   source->AddLocalizedString("title",
                              IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
   source->AddLocalizedString("toolbarTitle", IDS_MD_EXTENSIONS_TOOLBAR_TITLE);
   source->AddLocalizedString("search", IDS_MD_EXTENSIONS_SEARCH);
@@ skipping 162 matching lines @@
   source->DisableDenyXFrameOptions();
   return source;
 }
 
 }  // namespace
 
 ExtensionsUI::ExtensionsUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource* source = nullptr;
 
-  if (base::FeatureList::IsEnabled(features::kMaterialDesignExtensions)) {
+  bool is_md =
+      base::FeatureList::IsEnabled(features::kMaterialDesignExtensions);
+
+  if (is_md) {
     source = CreateMdExtensionsSource();
     InstallExtensionHandler* install_extension_handler =
         new InstallExtensionHandler();
     install_extension_handler->GetLocalizedValues(source);
     web_ui->AddMessageHandler(install_extension_handler);
   } else {
     source = CreateExtensionsHTMLSource();
 
     ExtensionSettingsHandler* handler = new ExtensionSettingsHandler();
     web_ui->AddMessageHandler(handler);
@@ skipping 19 matching lines @@
 #endif
 
     web_ui->AddMessageHandler(new MetricsHandler());
 
     // Need to allow <object> elements so that the <extensionoptions> browser
     // plugin can be loaded within chrome://extensions.
     source->OverrideContentSecurityPolicyObjectSrc("object-src 'self';");
   }
 
   content::WebUIDataSource::Add(profile, source);
+  // Handles its own lifetime.
+  new ExtensionWebUiTimer(web_ui->GetWebContents(), is_md);
 }
 
 ExtensionsUI::~ExtensionsUI() {}
 
 // static
 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes(
     ui::ScaleFactor scale_factor) {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor);
 }
 
 }  // namespace extensions