Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2341543002: Fix client integration script for blimp (Closed)

Created:
4 years, 3 months ago by nyquist
Modified:
4 years, 3 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix client integration script for blimp The CL https://codereview.chromium.org/2323993003/ was a bit overzealous in using chrome, and missed one _public in the script name for the command line shell script for chrome_public_apk. This CL fixes the shell script name. BUG=597756 Committed: https://crrev.com/b5aa913999a43e7bd20a126d8949c8aa47546ca4 Cr-Commit-Position: refs/heads/master@{#418417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M blimp/tools/client_engine_integration.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
nyquist
khushalsagar: PTAL
4 years, 3 months ago (2016-09-13 22:51:38 UTC) #2
Khushal
lgtm
4 years, 3 months ago (2016-09-13 22:53:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341543002/1
4 years, 3 months ago (2016-09-13 22:53:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 23:43:42 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 23:46:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5aa913999a43e7bd20a126d8949c8aa47546ca4
Cr-Commit-Position: refs/heads/master@{#418417}

Powered by Google App Engine
This is Rietveld 408576698