VM: Better handling of OOM errors in the background compiler

VM: Better handling of OOM errors in the background compiler

Don't expect to find a Dart frame on the stack when an exception
occurs in background compilation.  Propagate OOM error as an
unhandled exception, and disable optimization for the function
where it occurred.

BUG=#27206
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/743fe92c49c75d972c1743c8b5504e9bbafcc29d

[Florian Schneider, 2016-09-13 22:17:11]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-09-13 23:29:57]

lgtm

https://codereview.chromium.org/2341523002/diff/20001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/2341523002/diff/20001/runtime/vm/exceptions.c...
runtime/vm/exceptions.cc:150: if (frame == NULL) return false;
// No Dart frame.

https://codereview.chromium.org/2341523002/diff/20001/runtime/vm/exceptions.c...
runtime/vm/exceptions.cc:333: ASSERT(!thread->IsMutatorThread());
Maybe assert that incoming_exception is the preallocated OOM exceptions, since
preallocated_unhandled_exception is in fact
preallocated_unhandled_exception_for_oom_exception.

[Florian Schneider, 2016-09-14 00:13:21]

https://codereview.chromium.org/2341523002/diff/20001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/2341523002/diff/20001/runtime/vm/exceptions.c...
runtime/vm/exceptions.cc:150: if (frame == NULL) return false;
On 2016/09/13 23:29:56, rmacnak wrote:
> // No Dart frame.

Done.

https://codereview.chromium.org/2341523002/diff/20001/runtime/vm/exceptions.c...
runtime/vm/exceptions.cc:333: ASSERT(!thread->IsMutatorThread());
On 2016/09/13 23:29:56, rmacnak wrote:
> Maybe assert that incoming_exception is the preallocated OOM exceptions, since
> preallocated_unhandled_exception is in fact
> preallocated_unhandled_exception_for_oom_exception.

Done.

[Florian Schneider, 2016-09-14 00:13:54]

Description was changed from

==========
VM: Better handling of OOM errors in the background compiler

Don't expect to find a Dart frame on the stack when an exception
occurs in background compilation.  Propagate OOM error as an
unhandled exception, and disable optimization for the function
where it occurred.

BUG=#27206
==========

to

==========
VM: Better handling of OOM errors in the background compiler

Don't expect to find a Dart frame on the stack when an exception
occurs in background compilation.  Propagate OOM error as an
unhandled exception, and disable optimization for the function
where it occurred.

BUG=#27206
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/743fe92c49c75d972c1743c8b5504e9bbafcc29d
==========

[Florian Schneider, 2016-09-14 00:13:55]

Committed patchset #4 (id:60001) manually as
743fe92c49c75d972c1743c8b5504e9bbafcc29d (presubmit successful).