Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2780)

Unified Diff: content/renderer/accessibility/render_accessibility_impl.h

Issue 2341503002: Fix race condition causing DCHECK(ack_pending_) to trip. (Closed)
Patch Set: Update test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/render_accessibility_impl.h
diff --git a/content/renderer/accessibility/render_accessibility_impl.h b/content/renderer/accessibility/render_accessibility_impl.h
index 4920532a3f94bea97093bf2224f1d948465afddb..3a9fa71eb5741c597c212f0b61f4d8d2e00adb76 100644
--- a/content/renderer/accessibility/render_accessibility_impl.h
+++ b/content/renderer/accessibility/render_accessibility_impl.h
@@ -115,7 +115,7 @@ class CONTENT_EXPORT RenderAccessibilityImpl
// Handlers for messages from the browser to the renderer.
void OnDoDefaultAction(int acc_obj_id);
- void OnEventsAck();
+ void OnEventsAck(int ack_token);
void OnFatalError();
void OnHitTest(gfx::Point point);
void OnSetAccessibilityFocus(int acc_obj_id);
@@ -171,6 +171,9 @@ class CONTENT_EXPORT RenderAccessibilityImpl
// Whether we are processing a client-initiated action.
bool during_action_;
+ // Token to send with event messages so we know when they're acknowledged.
+ int ack_token_;
+
// So we can queue up tasks to be executed later.
base::WeakPtrFactory<RenderAccessibilityImpl> weak_factory_;
« no previous file with comments | « content/common/accessibility_messages.h ('k') | content/renderer/accessibility/render_accessibility_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698