Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: content/common/accessibility_messages.h

Issue 2341503002: Fix race condition causing DCHECK(ack_pending_) to trip. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/accessibility_messages.h
diff --git a/content/common/accessibility_messages.h b/content/common/accessibility_messages.h
index fb21af10664820840b884d6c03d681a883bb69b0..6beb9cc745a6466d82e9622e7bf33d223d336caa 100644
--- a/content/common/accessibility_messages.h
+++ b/content/common/accessibility_messages.h
@@ -181,8 +181,10 @@ IPC_MESSAGE_ROUTED1(AccessibilityMsg_SetAccessibilityFocus,
int /* object id */)
// Tells the render view that a AccessibilityHostMsg_Events
-// message was processed and it can send addition events.
-IPC_MESSAGE_ROUTED0(AccessibilityMsg_Events_ACK)
+// message was processed and it can send addition events. The argument
Tom Sepez 2016/09/13 21:31:49 nit: additional
dmazzoni 2016/09/14 18:59:26 Fixed
+// must be the same as the ack_token passed to AccessibilityHostMsg_Events.
+IPC_MESSAGE_ROUTED1(AccessibilityMsg_Events_ACK,
+ int /* ack_token */)
// Tell the renderer to reset and send a new accessibility tree from
// scratch because the browser is out of sync. It passes a sequential
@@ -207,15 +209,17 @@ IPC_MESSAGE_ROUTED1(AccessibilityMsg_SnapshotTree,
// Messages sent from the renderer to the browser.
// Sent to notify the browser about renderer accessibility events.
-// The browser responds with a AccessibilityMsg_Events_ACK.
+// The browser responds with a AccessibilityMsg_Events_ACK with the same
+// ack_token.
// The second parameter, reset_token, is set if this IPC was sent in response
// to a reset request from the browser. When the browser requests a reset,
// it ignores incoming IPCs until it sees one with the correct reset token.
// Any other time, it ignores IPCs with a reset token.
-IPC_MESSAGE_ROUTED2(
+IPC_MESSAGE_ROUTED3(
AccessibilityHostMsg_Events,
std::vector<AccessibilityHostMsg_EventParams> /* events */,
- int /* reset_token */)
+ int /* reset_token */,
+ int /* ack_token */)
// Sent to update the browser of the location of accessibility objects.
IPC_MESSAGE_ROUTED1(

Powered by Google App Engine
This is Rietveld 408576698