Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2341503002: Fix race condition causing DCHECK(ack_pending_) to trip. (Closed)
Patch Set: Update test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 void OnDidChangeFrameOwnerProperties(int32_t frame_routing_id, 696 void OnDidChangeFrameOwnerProperties(int32_t frame_routing_id,
697 const FrameOwnerProperties& properties); 697 const FrameOwnerProperties& properties);
698 void OnUpdateTitle(const base::string16& title, 698 void OnUpdateTitle(const base::string16& title,
699 blink::WebTextDirection title_direction); 699 blink::WebTextDirection title_direction);
700 void OnUpdateEncoding(const std::string& encoding); 700 void OnUpdateEncoding(const std::string& encoding);
701 void OnBeginNavigation(const CommonNavigationParams& common_params, 701 void OnBeginNavigation(const CommonNavigationParams& common_params,
702 const BeginNavigationParams& begin_params); 702 const BeginNavigationParams& begin_params);
703 void OnDispatchLoad(); 703 void OnDispatchLoad();
704 void OnAccessibilityEvents( 704 void OnAccessibilityEvents(
705 const std::vector<AccessibilityHostMsg_EventParams>& params, 705 const std::vector<AccessibilityHostMsg_EventParams>& params,
706 int reset_token); 706 int reset_token,
707 int ack_token);
707 void OnAccessibilityLocationChanges( 708 void OnAccessibilityLocationChanges(
708 const std::vector<AccessibilityHostMsg_LocationChangeParams>& params); 709 const std::vector<AccessibilityHostMsg_LocationChangeParams>& params);
709 void OnAccessibilityFindInPageResult( 710 void OnAccessibilityFindInPageResult(
710 const AccessibilityHostMsg_FindInPageResultParams& params); 711 const AccessibilityHostMsg_FindInPageResultParams& params);
711 void OnAccessibilityChildFrameHitTestResult(const gfx::Point& point, 712 void OnAccessibilityChildFrameHitTestResult(const gfx::Point& point,
712 int hit_obj_id); 713 int hit_obj_id);
713 void OnAccessibilitySnapshotResponse( 714 void OnAccessibilitySnapshotResponse(
714 int callback_id, 715 int callback_id,
715 const AXContentTreeUpdate& snapshot); 716 const AXContentTreeUpdate& snapshot);
716 void OnToggleFullscreen(bool enter_fullscreen); 717 void OnToggleFullscreen(bool enter_fullscreen);
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 1058
1058 // NOTE: This must be the last member. 1059 // NOTE: This must be the last member.
1059 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1060 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1060 1061
1061 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1062 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1062 }; 1063 };
1063 1064
1064 } // namespace content 1065 } // namespace content
1065 1066
1066 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1067 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698