Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8124)

Unified Diff: chrome/test/data/webui/settings/about_page_tests.js

Issue 2341493003: MD Settings: Deflake attempt for CrSettingsPrivacyPageTest.PrivacyPage. (Closed)
Patch Set: Check for specific value. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/about_page_tests.js
diff --git a/chrome/test/data/webui/settings/about_page_tests.js b/chrome/test/data/webui/settings/about_page_tests.js
index 1c70a7f55e8f17538ac9600c68f9e90c442b0a3e..46502194bc52018e237a10f9b23a2fc58d622426 100644
--- a/chrome/test/data/webui/settings/about_page_tests.js
+++ b/chrome/test/data/webui/settings/about_page_tests.js
@@ -606,20 +606,6 @@ cr.define('settings_about_page', function() {
}
function registerChannelSwitcherDialogTests() {
- /**
- * Converts an event occurrence to a promise.
- * @param {string} eventType
- * @param {!HTMLElement} target
- * @return {!Promise} A promise firing once the event occurs.
- * TODO(dpapad); Share this code with certificate_manager_page_test.js
- * identical helper method.
- */
- function eventToPromise(eventType, target) {
- return new Promise(function(resolve, reject) {
- target.addEventListener(eventType, resolve);
- });
- }
-
suite('ChannelSwitcherDialogTest', function() {
var dialog = null;
var radioButtons = null;
@@ -671,7 +657,7 @@ cr.define('settings_about_page', function() {
assertTrue(dialog.$.changeChannelAndPowerwash.hidden);
assertFalse(dialog.$.changeChannel.hidden);
- var whenTargetChannelChangedFired = eventToPromise(
+ var whenTargetChannelChangedFired = test_util.eventToPromise(
'target-channel-changed', dialog);
MockInteractions.tap(dialog.$.changeChannel);
@@ -696,7 +682,7 @@ cr.define('settings_about_page', function() {
assertFalse(dialog.$.changeChannelAndPowerwash.hidden);
assertTrue(dialog.$.changeChannel.hidden);
- var whenTargetChannelChangedFired = eventToPromise(
+ var whenTargetChannelChangedFired = test_util.eventToPromise(
'target-channel-changed', dialog);
MockInteractions.tap(dialog.$.changeChannelAndPowerwash);
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698