Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2341493002: Fix parsing of generic closure formal parameter (Closed)

Created:
4 years, 3 months ago by hausner
Modified:
4 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix parsing of generic closure formal parameter BUG=#27299 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/3e60d488429f6def6f0a6576edfb364a14a66a12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M runtime/vm/parser.cc View 1 chunk +13 lines, -9 lines 0 comments Download
M tests/language/language.status View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 3 months ago (2016-09-13 20:33:46 UTC) #3
regis
LGTM Thanks for the quick fix!
4 years, 3 months ago (2016-09-13 22:08:26 UTC) #4
hausner
4 years, 3 months ago (2016-09-13 22:11:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e60d488429f6def6f0a6576edfb364a14a66a12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698