Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2341483003: MultibufferDataSource: Handle HasSingleOrigin() before init completes. (Closed)

Created:
4 years, 3 months ago by sandersd (OOO until July 31)
Modified:
4 years, 3 months ago
Reviewers:
hubbe
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MultibufferDataSource: Handle HasSingleOrigin() before init completes. This extends the time that WebMediaPlayerImpl::hasSingleSecurityOrigin() returns true from "until the data source exists" to "until the data source is initialized". I've verified (by source code inspection) that every existing caller is safe with respect to races here. It seems to be an undocumented rule followed by Blink developers. BUG=638763 Committed: https://crrev.com/dfe8ede1f60884311bb9c0c36417e31c53babef4 Cr-Commit-Position: refs/heads/master@{#418472}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/blink/multibuffer_data_source.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sandersd (OOO until July 31)
4 years, 3 months ago (2016-09-13 22:40:48 UTC) #2
hubbe
lgtm https://codereview.chromium.org/2341483003/diff/1/media/blink/multibuffer_data_source.cc File media/blink/multibuffer_data_source.cc (right): https://codereview.chromium.org/2341483003/diff/1/media/blink/multibuffer_data_source.cc#newcode254 media/blink/multibuffer_data_source.cc:254: return true; single_origin_ defaults to true, so this ...
4 years, 3 months ago (2016-09-13 22:43:23 UTC) #3
sandersd (OOO until July 31)
https://codereview.chromium.org/2341483003/diff/1/media/blink/multibuffer_data_source.cc File media/blink/multibuffer_data_source.cc (right): https://codereview.chromium.org/2341483003/diff/1/media/blink/multibuffer_data_source.cc#newcode254 media/blink/multibuffer_data_source.cc:254: return true; On 2016/09/13 22:43:23, hubbe wrote: > single_origin_ ...
4 years, 3 months ago (2016-09-13 22:50:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341483003/20001
4 years, 3 months ago (2016-09-13 22:51:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 03:11:10 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:13:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfe8ede1f60884311bb9c0c36417e31c53babef4
Cr-Commit-Position: refs/heads/master@{#418472}

Powered by Google App Engine
This is Rietveld 408576698