Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2341453002: CFX_FloatPoint default constructor and equals operators (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

CFX_FloatPoint default constructor and equals operators Committed: https://pdfium.googlesource.com/pdfium/+/63f545c485c063831ecb58fb492f96fe5f462fd1

Patch Set 1 #

Patch Set 2 : Simplify comparison. #

Patch Set 3 : rebase #

Patch Set 4 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -111 lines) Patch
M core/fpdfdoc/cpvt_generateap.cpp View 1 4 chunks +6 lines, -7 lines 0 comments Download
M core/fpdfdoc/include/cpvt_line.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfdoc/include/cpvt_word.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M core/fxcrt/include/fx_coordinates.h View 1 chunk +6 lines, -0 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 2 3 chunks +32 lines, -36 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 8 chunks +13 lines, -18 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.cpp View 1 5 chunks +4 lines, -20 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 4 chunks +8 lines, -15 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-13 19:12:18 UTC) #3
dsinclair
lgtm
4 years, 3 months ago (2016-09-13 19:16:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341453002/40001
4 years, 3 months ago (2016-09-13 20:43:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/2039)
4 years, 3 months ago (2016-09-13 20:58:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341453002/60001
4 years, 3 months ago (2016-09-13 23:08:33 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 23:08:52 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/63f545c485c063831ecb58fb492f96fe5f46...

Powered by Google App Engine
This is Rietveld 408576698