Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2341433003: [css-grid] Fix excesive usage of SubtreeLayoutScope (Closed)

Created:
4 years, 3 months ago by svillar
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, svillar, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix excesive usage of SubtreeLayoutScope The purpose of the class is to mark a subtree as needing layout mainly for multipass layout. We should just use LayoutObject->setNeedsLayout() Committed: https://crrev.com/968cc7566cefe704ffee161725c4c547c4dc8493 Cr-Commit-Position: refs/heads/master@{#418576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
svillar
4 years, 3 months ago (2016-09-14 10:51:20 UTC) #2
jfernandez
lgtm
4 years, 3 months ago (2016-09-14 11:11:15 UTC) #3
cbiesinger1
On 2016/09/14 11:11:15, jfernandez wrote: > lgtm Lgtm
4 years, 3 months ago (2016-09-14 12:34:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341433003/1
4 years, 3 months ago (2016-09-14 14:26:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 16:11:09 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:12:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/968cc7566cefe704ffee161725c4c547c4dc8493
Cr-Commit-Position: refs/heads/master@{#418576}

Powered by Google App Engine
This is Rietveld 408576698