Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: src/object-observe.js

Issue 234143002: Remove unnecessary %UnwrapGlobalProxy calls from object-observe.js (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 return observationState; 73 return observationState;
74 } 74 }
75 75
76 function GetWeakMapWrapper() { 76 function GetWeakMapWrapper() {
77 function MapWrapper(map) { 77 function MapWrapper(map) {
78 this.map_ = map; 78 this.map_ = map;
79 }; 79 };
80 80
81 MapWrapper.prototype = { 81 MapWrapper.prototype = {
82 get: function(key) { 82 get: function(key) {
83 key = %UnwrapGlobalProxy(key);
84 if (!IS_SPEC_OBJECT(key)) return UNDEFINED;
85 return %WeakCollectionGet(this.map_, key); 83 return %WeakCollectionGet(this.map_, key);
86 }, 84 },
87 set: function(key, value) { 85 set: function(key, value) {
88 key = %UnwrapGlobalProxy(key);
89 if (!IS_SPEC_OBJECT(key)) return UNDEFINED;
90 %WeakCollectionSet(this.map_, key, value); 86 %WeakCollectionSet(this.map_, key, value);
91 }, 87 },
92 has: function(key) { 88 has: function(key) {
93 return !IS_UNDEFINED(this.get(key)); 89 return !IS_UNDEFINED(this.get(key));
94 } 90 }
95 }; 91 };
96 92
97 return MapWrapper; 93 return MapWrapper;
98 } 94 }
99 95
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 "observe", ArrayObserve, 640 "observe", ArrayObserve,
645 "unobserve", ArrayUnobserve 641 "unobserve", ArrayUnobserve
646 )); 642 ));
647 InstallFunctions(notifierPrototype, DONT_ENUM, $Array( 643 InstallFunctions(notifierPrototype, DONT_ENUM, $Array(
648 "notify", ObjectNotifierNotify, 644 "notify", ObjectNotifierNotify,
649 "performChange", ObjectNotifierPerformChange 645 "performChange", ObjectNotifierPerformChange
650 )); 646 ));
651 } 647 }
652 648
653 SetupObjectObserve(); 649 SetupObjectObserve();
OLDNEW
« no previous file with comments | « no previous file | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698