Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2341423002: Don't include LayoutBlock.h from MediaControlElementTypes.h (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
haraken, eae
CC:
chromium-reviews, blink-reviews-html_chromium.org, nektar+watch_chromium.org, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, dmazzoni+watch_chromium.org, Srirama, aboxhall, aboxhall+watch_chromium.org, szager+layoutwatch_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, nessy, zoltan1, blink-reviews-layout_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, haraken, vcarbune.chromium, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, slimming-paint-reviews_chromium.org, nektarios, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include LayoutBlock.h from MediaControlElementTypes.h Reduces the dependencies on LayoutBlock.h by 5 compilation units. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/bda6aca3ee1b6514da7c849e9c8243e2ee2f41fd Cr-Commit-Position: refs/heads/master@{#419699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-16 20:44:35 UTC) #6
eae
LGTM
4 years, 3 months ago (2016-09-17 08:29:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341423002/1
4 years, 3 months ago (2016-09-17 08:30:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/261695)
4 years, 3 months ago (2016-09-17 08:37:15 UTC) #13
haraken
owner LGTM
4 years, 3 months ago (2016-09-17 12:38:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341423002/1
4 years, 3 months ago (2016-09-20 07:12:13 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 08:30:07 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 08:32:29 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bda6aca3ee1b6514da7c849e9c8243e2ee2f41fd
Cr-Commit-Position: refs/heads/master@{#419699}

Powered by Google App Engine
This is Rietveld 408576698