Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2341403004: Revert of Update MB to use `gn analyze`. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update MB to use `gn analyze`. (patchset #9 id:160001 of https://codereview.chromium.org/2298403002/ ) Reason for revert: Need to add "aura_builder", probably others ... Original issue's description: > Update MB to use `gn analyze`. > > Now that GN supports a form of `analyze` directly, this patch > updates //tools/mb to use it rather than working awkwardly through > `gn refs`. The MB implementation now is mostly responsible for > mapping ninja targets to labels, calling GN, and then mapping returned > labels back to ninja targets. Eventually we should update the > recipes to just pass labels around instead. > > One significant change is that now we need entries in gn_isolate_map.pyl > for every target listed in 'additional_compile_targets' and > 'isolated_scripts' as well as in 'gtest_tests', because we have to remap > everything to the GN labels, not just tests for swarming. > > We should switch everything to using GN labels directly, but that'll require > follow-on CLs. > > R=brettw@chromium.org > BUG=555273 > > Committed: https://crrev.com/9aba8b21177df3ed3e897d5c500d845fbf5523e6 > Cr-Commit-Position: refs/heads/master@{#419315} TBR=phajdan.jr@chromium.org,brettw@chromium.org,kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555273 Committed: https://crrev.com/10118bffe51b2b751cc568dddf772a74cd9b8dbd Cr-Commit-Position: refs/heads/master@{#419321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -257 lines) Patch
M testing/buildbot/gn_isolate_map.pyl View 10 chunks +8 lines, -71 lines 0 comments Download
M testing/buildbot/manage.py View 3 chunks +30 lines, -39 lines 0 comments Download
M tools/mb/mb.py View 20 chunks +130 lines, -127 lines 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +60 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of Update MB to use `gn analyze`.
4 years, 3 months ago (2016-09-16 23:15:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341403004/1
4 years, 3 months ago (2016-09-16 23:15:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 23:16:26 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 23:18:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10118bffe51b2b751cc568dddf772a74cd9b8dbd
Cr-Commit-Position: refs/heads/master@{#419321}

Powered by Google App Engine
This is Rietveld 408576698