Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23414008: Revert "Snapshot i18n Javascript code" and "Fix mjsunit/debug-script after r16298". (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Revert "Snapshot i18n Javascript code" and "Fix mjsunit/debug-script after r16298". This reverts r16298 and r16303 due to ChromeOS browser_tests failures ("Uncaught ReferenceError: Boolean is not defined" in --gtest_filter="FileDisplay/FileManagerBrowserTest.Test/0" and others) R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2423 lines, -2194 lines) Patch
M src/api.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +13 lines, -0 lines 0 comments Download
A src/extensions/i18n/break-iterator.js View 1 chunk +190 lines, -0 lines 0 comments Download
A src/extensions/i18n/collator.js View 1 chunk +209 lines, -0 lines 0 comments Download
A src/extensions/i18n/date-format.js View 1 chunk +474 lines, -0 lines 0 comments Download
A + src/extensions/i18n/footer.js View 1 chunk +11 lines, -15 lines 0 comments Download
A src/extensions/i18n/globals.js View 1 chunk +168 lines, -0 lines 0 comments Download
A + src/extensions/i18n/header.js View 1 chunk +11 lines, -6 lines 0 comments Download
A + src/extensions/i18n/i18n-extension.h View 1 chunk +16 lines, -12 lines 0 comments Download
A + src/extensions/i18n/i18n-extension.cc View 1 chunk +16 lines, -30 lines 0 comments Download
A src/extensions/i18n/i18n-utils.js View 1 chunk +536 lines, -0 lines 0 comments Download
A src/extensions/i18n/locale.js View 1 chunk +190 lines, -0 lines 0 comments Download
A src/extensions/i18n/number-format.js View 1 chunk +289 lines, -0 lines 0 comments Download
A src/extensions/i18n/overrides.js View 1 chunk +220 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
D src/i18n.js View 1 chunk +0 lines, -2116 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/natives.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +44 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Michael: since you reviewed the original, you also get to review the revert :-) Jochen: ...
7 years, 3 months ago (2013-08-26 16:54:21 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 3 months ago (2013-08-26 16:55:51 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-08-26 17:01:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r16336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698