Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2341393002: Remove stl_util's STLDeleteContainerPairSecondPointers from net/. (Closed)

Created:
4 years, 3 months ago by Avi (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's STLDeleteContainerPairSecondPointers from net/. BUG=555865 Committed: https://crrev.com/c39cece91ec71b0fc9af21544b772622f236cb6f Cr-Commit-Position: refs/heads/master@{#419320}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -32 lines) Patch
M net/server/http_server.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/server/http_server.cc View 1 5 chunks +13 lines, -13 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 5 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Avi (use Gerrit)
4 years, 3 months ago (2016-09-16 19:33:11 UTC) #4
davidben
lgtm https://codereview.chromium.org/2341393002/diff/1/net/server/http_server.cc File net/server/http_server.cc (right): https://codereview.chromium.org/2341393002/diff/1/net/server/http_server.cc#newcode113 net/server/http_server.cc:113: id_to_connection_.erase(connection_id); Nit: id_to_connection_.erase(it) to save a lookup?
4 years, 3 months ago (2016-09-16 22:11:13 UTC) #7
Avi (use Gerrit)
https://codereview.chromium.org/2341393002/diff/1/net/server/http_server.cc File net/server/http_server.cc (right): https://codereview.chromium.org/2341393002/diff/1/net/server/http_server.cc#newcode113 net/server/http_server.cc:113: id_to_connection_.erase(connection_id); On 2016/09/16 22:11:13, davidben wrote: > Nit: id_to_connection_.erase(it) ...
4 years, 3 months ago (2016-09-16 22:14:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341393002/20001
4 years, 3 months ago (2016-09-16 22:16:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 23:10:38 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 23:12:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c39cece91ec71b0fc9af21544b772622f236cb6f
Cr-Commit-Position: refs/heads/master@{#419320}

Powered by Google App Engine
This is Rietveld 408576698