MD Settings: Fix pointer for paper-dropdown-menu-light.

MD Settings: Fix pointer for paper-dropdown-menu-light.

BUG=640937, 640167
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/887edc5948a0b12632147c066cbdb841e5ee4717
Cr-Commit-Position: refs/heads/master@{#419292}

[dpapad, 2016-09-16 18:08:43]

Description was changed from

==========
MD Settings: Fix pointer for dropdown menus.

BUG=640937,640167
==========

to

==========
MD Settings: Fix pointer for dropdown menus.

BUG=640937,640167
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-16 18:17:21]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-09-16 18:17:22]

https://codereview.chromium.org/2341383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2341383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:87: iron-dropdown
.dropdown-content .dropdown-item:not([disabled]),
Should we just merge the two selectors to

.dropdown-item:not([disabled])

I don't think we have any dropdown-item instances that are not children of
paper-dropdown-menu-light, or cr-shared-menu (same question for lines 58-59).

[Dan Beam, 2016-09-16 18:29:44]

https://codereview.chromium.org/2341383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2341383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:87: iron-dropdown
.dropdown-content .dropdown-item:not([disabled]),
On 2016/09/16 18:17:22, dpapad wrote:
> Should we just merge the two selectors to
> 
> .dropdown-item:not([disabled])
> 
> I don't think we have any dropdown-item instances that are not children of
> paper-dropdown-menu-light, or cr-shared-menu (same question for lines 58-59).

if that's specific enough, sgtm

alsoooo, :-webkit-any() is a thing

:-webkit-any(iron-dropdown, paper-dropdown-menu-light)
.dropdown-item:not([disabled])

[dschuyler, 2016-09-16 19:20:24]

lgtm

[dpapad, 2016-09-16 20:49:00]

On 2016/09/16 at 18:29:44, dbeam wrote:
>
https://codereview.chromium.org/2341383002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/settings_shared_css.html (right):
> 
>
https://codereview.chromium.org/2341383002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/settings_shared_css.html:87: iron-dropdown
.dropdown-content .dropdown-item:not([disabled]),
> On 2016/09/16 18:17:22, dpapad wrote:
> > Should we just merge the two selectors to
> > 
> > .dropdown-item:not([disabled])
> > 
> > I don't think we have any dropdown-item instances that are not children of
> > paper-dropdown-menu-light, or cr-shared-menu (same question for lines
58-59).
> 
> if that's specific enough, sgtm
I double checked that all .dropdown-item instances are children of
paper-dropdown-menu-light, cr-shared-menu or iron-dropdown and so I simplified
those CSS selectors. Specificity seems to be OK.

> 
> alsoooo, :-webkit-any() is a thing
> 
> :-webkit-any(iron-dropdown, paper-dropdown-menu-light)
.dropdown-item:not([disabled])

[dpapad, 2016-09-16 20:49:38]

Description was changed from

==========
MD Settings: Fix pointer for dropdown menus.

BUG=640937,640167
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix pointer for paper-dropdown-menu-light.

BUG=640937,640167
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-16 20:52:00]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-09-16 20:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2341383002/#ps40001
(title: "Condense")

[commit-bot: I haz the power, 2016-09-16 20:52:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:07:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 22:09:11]

Description was changed from

==========
MD Settings: Fix pointer for paper-dropdown-menu-light.

BUG=640937,640167
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix pointer for paper-dropdown-menu-light.

BUG=640937,640167
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/887edc5948a0b12632147c066cbdb841e5ee4717
Cr-Commit-Position: refs/heads/master@{#419292}
==========

[commit-bot: I haz the power, 2016-09-16 22:09:13]

Patchset 3 (id:??) landed as
https://crrev.com/887edc5948a0b12632147c066cbdb841e5ee4717
Cr-Commit-Position: refs/heads/master@{#419292}