Reduce duplicated code in CPDF_Document by adding auxiliary methods

Reduce duplicated code in CPDF_Document by adding auxiliary methods

ProcessbCJK and CalculateFontDesc methods are used to reduce the code
duplication between AddFont and AddWindowsFont methods.

Committed: https://pdfium.googlesource.com/pdfium/+/e9988dd65e743a9b70482aa3007cec2c9789f679

[npm, 2016-09-16 18:26:22]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:26:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-09-16 18:27:05]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org, weili@chromium.org

[npm, 2016-09-16 18:27:06]

PTAL

[commit-bot: I haz the power, 2016-09-16 18:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:34:50]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[npm, 2016-09-16 18:47:34]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:47:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:57:51]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-16 19:42:14]

lgtm

https://codereview.chromium.org/2341373003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/2341373003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:871: auto Insert = [&](FX_WCHAR
start, FX_WCHAR end, CPDF_Array* widthArr) {
nit: local not needed, it's much more fun to have the lambda inside the function
call itself. Also, can we be specific about what we capture, and capture by
value where possible?

[Tom Sepez, 2016-09-16 19:49:08]

https://codereview.chromium.org/2341373003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_document.h (right):

https://codereview.chromium.org/2341373003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_document.h:10: #include <memory>
nit: #include <functional>

[npm, 2016-09-16 20:26:37]

The CQ bit was checked by npm@chromium.org

[npm, 2016-09-16 20:26:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2341373003/#ps40001
(title: "Nits")

[commit-bot: I haz the power, 2016-09-16 20:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-09-16 20:32:36]

The CQ bit was checked by npm@chromium.org

[npm, 2016-09-16 20:32:36]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2341373003/#ps60001
(title: "Typo")

[commit-bot: I haz the power, 2016-09-16 20:32:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:57:25]

Description was changed from

==========
Reduce duplicated code in CPDF_Document by adding auxiliary methods

ProcessbCJK and CalculateFontDesc methods are used to reduce the code
duplication between AddFont and AddWindowsFont methods.
==========

to

==========
Reduce duplicated code in CPDF_Document by adding auxiliary methods

ProcessbCJK and CalculateFontDesc methods are used to reduce the code
duplication between AddFont and AddWindowsFont methods.

Committed:
https://pdfium.googlesource.com/pdfium/+/e9988dd65e743a9b70482aa3007cec2c9789...
==========

[commit-bot: I haz the power, 2016-09-16 20:57:26]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/e9988dd65e743a9b70482aa3007cec2c9789...