Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2341353002: Revert of Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target (patchset #1 id:1 of https://codereview.chromium.org/2286623002/ ) Reason for revert: Reverting, because Dr. Memory test bots need that executable. It didn't break until a clobber landed and deleted the executable generated in the past. Also glider@ reports that chrome_app_unittests was probably innocent (in the bug report) anyways. First breaking build: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/130 Original issue's description: > Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target > > This should probably fix the compile step on the Dr. Memory builder. > > BUG=640185 > TBR=dpranke@chromium.org,cpu@chromium.org > NOTRY=true > > Committed: https://crrev.com/48586ee56e601e60095f30723060d4bd888ce6fe > Cr-Commit-Position: refs/heads/master@{#414670} TBR=cpu@chromium.org,dpranke@chromium.org,glider@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=640185 Committed: https://crrev.com/cb7b52a1f850f93570bd514a04f80ad89bf317c0 Cr-Commit-Position: refs/heads/master@{#419219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tommycli
Created Revert of Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target
4 years, 3 months ago (2016-09-16 17:21:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341353002/1
4 years, 3 months ago (2016-09-16 17:22:34 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 17:45:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 18:16:12 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:18:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb7b52a1f850f93570bd514a04f80ad89bf317c0
Cr-Commit-Position: refs/heads/master@{#419219}

Powered by Google App Engine
This is Rietveld 408576698