Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2341343002: [DevTools] Remove outline-disclosure and sidebar-tree. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove outline-disclosure and sidebar-tree. These are not used anymore. BUG=none Committed: https://crrev.com/d940250057b72794929c8a933ffcd882a978899e Cr-Commit-Position: refs/heads/master@{#419262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -524 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/SidebarTreeElement.js View 1 chunk +0 lines, -180 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorStyle.css View 2 chunks +0 lines, -342 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-09-16 17:33:09 UTC) #2
lushnikov
lgtm
4 years, 3 months ago (2016-09-16 18:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341343002/1
4 years, 3 months ago (2016-09-16 18:39:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 20:03:44 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:06:02 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d940250057b72794929c8a933ffcd882a978899e
Cr-Commit-Position: refs/heads/master@{#419262}

Powered by Google App Engine
This is Rietveld 408576698