Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2414)

Unified Diff: cc/tiles/tile_manager.cc

Issue 2341323003: cc: Add temporary CHECKs to debug TileManager crash. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/tile_manager.cc
diff --git a/cc/tiles/tile_manager.cc b/cc/tiles/tile_manager.cc
index 7e214697f509df2310b20d847d0fdd8aa59c1cc0..20a29ad8d0297d68109bb7cf9ef835f0ae248bc2 100644
--- a/cc/tiles/tile_manager.cc
+++ b/cc/tiles/tile_manager.cc
@@ -414,6 +414,8 @@ void TileManager::DidFinishRunningTileTasksRequiredForActivation() {
"TileManager::DidFinishRunningTileTasksRequiredForActivation");
TRACE_EVENT_ASYNC_STEP_INTO1("cc", "ScheduledTasks", this, "running", "state",
ScheduledTasksStateAsValue());
+ // TODO(vmpstr): Temporary check to debug crbug.com/642927.
+ CHECK(tile_task_manager_);
signals_.ready_to_activate = true;
signals_check_notifier_.Schedule();
}
@@ -422,6 +424,8 @@ void TileManager::DidFinishRunningTileTasksRequiredForDraw() {
TRACE_EVENT0("cc", "TileManager::DidFinishRunningTileTasksRequiredForDraw");
TRACE_EVENT_ASYNC_STEP_INTO1("cc", "ScheduledTasks", this, "running", "state",
ScheduledTasksStateAsValue());
+ // TODO(vmpstr): Temporary check to debug crbug.com/642927.
+ CHECK(tile_task_manager_);
signals_.ready_to_draw = true;
signals_check_notifier_.Schedule();
}
@@ -442,6 +446,8 @@ void TileManager::DidFinishRunningAllTileTasks() {
// TODO(ericrk): We should find a better way to safely handle re-entrant
// notifications than always having to schedule a new task.
// http://crbug.com/498439
+ // TODO(vmpstr): Temporary check to debug crbug.com/642927.
+ CHECK(tile_task_manager_);
signals_.all_tile_tasks_completed = true;
signals_check_notifier_.Schedule();
return;
@@ -1149,6 +1155,8 @@ void TileManager::CheckIfMoreTilesNeedToBePrepared() {
resource_pool_->ReduceResourceUsage();
image_manager_.ReduceMemoryUsage();
+ // TODO(vmpstr): Temporary check to debug crbug.com/642927.
+ CHECK(tile_task_manager_);
signals_.all_tile_tasks_completed = true;
signals_check_notifier_.Schedule();
@@ -1179,6 +1187,8 @@ void TileManager::CheckIfMoreTilesNeedToBePrepared() {
global_state_.tree_priority,
RasterTilePriorityQueue::Type::REQUIRED_FOR_DRAW));
+ // TODO(vmpstr): Temporary check to debug crbug.com/642927.
+ CHECK(tile_task_manager_);
DCHECK(IsReadyToActivate());
DCHECK(IsReadyToDraw());
signals_.ready_to_activate = need_to_signal_activate;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698